DG-DEN-14646_Fpga Alarm Properties And Timing 3

Activity

DG-DEN-14646-1 52

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    wbracken  (deleted user)
    Author & Moderator 1h 59m 15 Corrected
    Reviewer - Complete 1h 8m 24 RESOLVED in CODE WALKTHROUGH.
    Reviewer - 0% reviewed 0m    
    jtaylor  (deleted user)
    Reviewer completed
    Reviewer - Complete 2h 6 RESOLVED IN CODE WALKTHROUGH.
    Reviewer - Complete 43m 6 RESOLVED IN CODE WALKTHROUGH.
    Reviewer - 19% reviewed 2m 1 RESOLVED IN CODE WALKTHROUGH
    Reviewer - 0% reviewed      
    Total   5h 54m 52  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /AlarmDefs.h Changed
    /firmware/.../Controllers/ConductivitySensors.c Changed 24
    /firmware/App/Controllers/Heaters.c Changed 2
    /firmware/App/Controllers/LoadCell.c Changed
    /firmware/.../Controllers/TemperatureSensors.c Changed 3
    /firmware/App/Controllers/Valves.c Changed 7
    /firmware/App/Controllers/Voltages.c Changed
    /firmware/App/Controllers/Voltages.h Changed 2
    /firmware/App/Services/FPGA.c Changed 5
    /firmware/App/Services/WatchdogMgmt.c Changed 3
    /Accel.c Changed
    /PersistentAlarm.c Changed
    /PersistentAlarm.h Changed
    /Utilities.c Changed 6
    /Utilities.h Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time