This is a list of all comments for DG-DEN-14689-1.

Review Summary: No summary


----------------------------------------
File: MsgDefs.h
Revision Comment by Sean Nash on 27 February 2023, 10:12 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16516

  I don't see DG changes using new ENUM names.

  Reply by Michael Garthwaite on 02 March 2023, 10:28
  > happens in FW common. This branch wasn't created at the start
  > and our automated scripted ended up created its own code
  > review. See:
  > http://devapps.diality.us:8060/cru/DG-DEN-14689-2 
  > Ill reorganize the review naming shortly.

    Reply by Sean Nash on 03 March 2023, 14:47
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 24 February 2023, 13:40 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16507

  //* ?

  Reply by wbracken on 01 March 2023, 13:10
  > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 24 February 2023, 13:40 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16508

  //* ?

  Reply by wbracken on 01 March 2023, 13:11
  > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 24 February 2023, 13:41 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16509

  //* ?

  Reply by wbracken on 01 March 2023, 13:11
  > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 24 February 2023, 13:42 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16510

  //* ?

  Reply by wbracken on 01 March 2023, 13:10
  > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 02 March 2023, 10:18 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16561

  Should this have _REQUEST added to end?

  Reply by Michael Garthwaite on 08 March 2023, 16:53
  > Fixed. Thanks!

    Reply by Sean Nash on 08 March 2023, 18:53
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by jtaylor on 27 February 2023, 08:44 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16511

  Comment alignment (3x 147, 151, 157)

  Reply by jtaylor on 02 March 2023, 08:23
  > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 02 March 2023, 10:20 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16563

  Should REQUEST be moved to end of name?  Seems like there are
  many enum names where REQUEST is not at end of name.

  Reply by Michael Garthwaite on 08 March 2023, 16:53
  > Fixed. Thanks!

    Reply by Sean Nash on 08 March 2023, 18:52
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 March 2023, 10:19 
https://devapps.diality.us/cru/DG-DEN-14689-1#c16562

  Is this a response to request above or a data broadcast?

  Reply by Michael Garthwaite on 02 March 2023, 10:29
  > I believe this MSG_ID is being removed in another branch

    Reply by Sean Nash on 03 March 2023, 14:46
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14689-1 https://devapps.diality.us/cru/DG-DEN-14689-1

Title: DG-DEN-14689_Messaging Bugs_DGFW_and_Common
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (5 active, 1 completed*)
     Sean Nash   (*)
     wbracken
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe