This is a list of all comments for DG-DEN-14706-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by jtaylor on 18 August 2023, 09:33 
https://devapps.diality.us/cru/DG-DEN-14706-1#c18623

  Suggest aligning comments in the block above

  Reply by Sean Nash on 18 August 2023, 09:58
  > I don't see where this #define is ever used.  Remove if not
  > needed.

    Reply by Michael Garthwaite on 18 August 2023, 12:35
    > Removed #define. Thanks!

      Reply by Sean Nash on 21 August 2023, 11:10
      > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 18 August 2023, 09:57 
https://devapps.diality.us/cru/DG-DEN-14706-1#c18626

  I think override should be OR'd with timeout only.  The used
  condition should still have to be true even if override is in
  place.

  Reply by Sean Nash on 18 August 2023, 11:04
  > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14706-1 https://devapps.diality.us/cru/DG-DEN-14706-1

Title: DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked 
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe