This is a list of all comments for DG-DEN-14763-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/ModeHeatDisinfect.c Revision Comment by jtaylor on 21 February 2023, 13:48 https://devapps.diality.us/cru/DG-DEN-14763-1#c16498 The revised comment doesn't make sense. What creates the flow exactly? Reply by Dara Navaei on 15 March 2023, 17:18 > Revised the comment. Reply by jtaylor on 16 March 2023, 09:44 > RESOLVED IN CODE WALKTHROUGH. ---------------------------------------- File: HDDefs.h Revision Comment by Sean Nash on 20 March 2023, 08:36 https://devapps.diality.us/cru/DG-DEN-14763-1#c16866 Why lower case when others are uppercase? Reply by Dara Navaei on 20 March 2023, 09:28 > Done Reply by Sean Nash on 20 March 2023, 09:48 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/.ccsproject Revision Comment by Sean Nash on 27 February 2023, 09:54 https://devapps.diality.us/cru/DG-DEN-14763-1#c16513 What is this setting and why did it change? Reply by Dara Navaei on 18 March 2023, 14:36 > This is to find the target configuration which in our case it > is XDS-110 automatically. It seems the .ccxml file in the > targetConfigs folder sets the right debugger and target > regardless of this check box being true or false. I set it > back to true to be consistent. Reply by Sean Nash on 20 March 2023, 08:48 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by Sean Nash on 20 March 2023, 23:50 https://devapps.diality.us/cru/DG-DEN-14763-1#c16901 This seems wrong. Reply by Dara Navaei on 21 March 2023, 08:28 > Done Reply by Sean Nash on 21 March 2023, 08:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 March 2023, 23:50 https://devapps.diality.us/cru/DG-DEN-14763-1#c16902 This seems wrong. Reply by Dara Navaei on 21 March 2023, 08:30 > Done Reply by Sean Nash on 21 March 2023, 08:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeHeatDisinfectActiveCool.c Revision Comment by wbracken on 21 February 2023, 14:11 https://devapps.diality.us/cru/DG-DEN-14763-1#c16499 Add comments and alignment. Reply by Dara Navaei on 15 March 2023, 17:17 > Done. Reply by wbracken on 16 March 2023, 12:12 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 20 March 2023, 08:43 https://devapps.diality.us/cru/DG-DEN-14763-1#c16868 Missing comment? Reply by Dara Navaei on 20 March 2023, 09:28 > Done Reply by Sean Nash on 20 March 2023, 09:48 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 16 March 2023, 22:08 https://devapps.diality.us/cru/DG-DEN-14763-1#c16846 Comment alignment. Reply by Dara Navaei on 17 March 2023, 14:42 > Done Reply by wbracken on 20 March 2023, 13:32 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 21 February 2023, 14:13 https://devapps.diality.us/cru/DG-DEN-14763-1#c16500 Add function headers. Reply by wbracken on 14 March 2023, 09:11 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 14 March 2023, 09:12 https://devapps.diality.us/cru/DG-DEN-14763-1#c16708 Add function header. Reply by Dara Navaei on 15 March 2023, 17:06 > Done. Reply by wbracken on 16 March 2023, 11:20 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 21 February 2023, 14:14 https://devapps.diality.us/cru/DG-DEN-14763-1#c16501 Add tempBelowTargetStartTimeMS and rsrvrsStatus. Reply by Dara Navaei on 15 March 2023, 17:08 > tempBelowTargetStartTimeMS is not longer set in this state. Reply by wbracken on 16 March 2023, 11:21 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 21 February 2023, 14:15 https://devapps.diality.us/cru/DG-DEN-14763-1#c16502 Add function headers. Reply by Dara Navaei on 15 March 2023, 17:07 > Done. Reply by wbracken on 16 March 2023, 12:11 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 20 March 2023, 08:42 https://devapps.diality.us/cru/DG-DEN-14763-1#c16867 Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID. Reply by Dara Navaei on 20 March 2023, 09:34 > Done. Thanks for catching it. Reply by Sean Nash on 20 March 2023, 09:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 14 March 2023, 09:15 https://devapps.diality.us/cru/DG-DEN-14763-1#c16711 Function header. Reply by Dara Navaei on 15 March 2023, 17:05 > Done. Reply by wbracken on 16 March 2023, 11:37 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 21 February 2023, 14:15 https://devapps.diality.us/cru/DG-DEN-14763-1#c16503 Add function header. Reply by Dara Navaei on 15 March 2023, 17:06 > Done Reply by wbracken on 16 March 2023, 11:22 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 14 March 2023, 09:14 https://devapps.diality.us/cru/DG-DEN-14763-1#c16709 Function header. Reply by Dara Navaei on 15 March 2023, 17:05 > Done. Reply by wbracken on 16 March 2023, 12:06 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 14 March 2023, 09:14 https://devapps.diality.us/cru/DG-DEN-14763-1#c16710 Function header. Reply by Dara Navaei on 15 March 2023, 17:05 > Done. Reply by wbracken on 16 March 2023, 12:07 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 14 March 2023, 09:16 https://devapps.diality.us/cru/DG-DEN-14763-1#c16712 Function header. Reply by Dara Navaei on 15 March 2023, 17:05 > Done. Reply by wbracken on 16 March 2023, 12:07 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 14 March 2023, 09:17 https://devapps.diality.us/cru/DG-DEN-14763-1#c16713 Function header. Reply by Dara Navaei on 15 March 2023, 17:05 > Done. Reply by wbracken on 16 March 2023, 12:07 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 14 March 2023, 09:17 https://devapps.diality.us/cru/DG-DEN-14763-1#c16714 Function header. Reply by Dara Navaei on 15 March 2023, 17:05 > Done. Reply by wbracken on 16 March 2023, 12:08 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: NVDataMgmtDGRecords.h Revision Comment by jtaylor on 17 March 2023, 08:43 https://devapps.diality.us/cru/DG-DEN-14763-1#c16847 I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS". This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix. Reply by Sean Nash on 20 March 2023, 08:55 > Not all of these are disinfect usage (e.g. RO water > generated) so I don't think disinfect_usage is appropriate. > I am ok with usage_info, though I think DG_USAGE_INFO is > better. Reply by jtaylor on 20 March 2023, 16:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by wbracken on 14 March 2023, 09:19 https://devapps.diality.us/cru/DG-DEN-14763-1#c16715 Add concCap and diaCap to header. Reply by Dara Navaei on 15 March 2023, 17:05 > They are local variables Reply by wbracken on 16 March 2023, 12:10 > RESOLVED IN CODE WALKTHROUGH --- ID: DG-DEN-14763-1 https://devapps.diality.us/cru/DG-DEN-14763-1 Title: DG-DEN-14763_DG HD Dev HD DG Dvt Update Part 10 Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (6 active, 0 completed*) Sean Nash Michael Garthwaite wbracken Darren Cox jtaylor Steve Jarpe