This is a list of all comments for DG-DEN-14834-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Heaters.c
Revision Comment by Sean Nash on 06 March 2023, 16:52 
https://devapps.diality.us/cru/DG-DEN-14834-2#c16594

  Comments for these target flows should explain why they're here
  (instead of just getting flow from flow module).

  Reply by Dara Navaei on 07 March 2023, 11:04
  > Done.

    Reply by Sean Nash on 07 March 2023, 11:16
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 06 March 2023, 16:49 
https://devapps.diality.us/cru/DG-DEN-14834-2#c16592

  What is the point of subtracting 0.0?

  Reply by Dara Navaei on 07 March 2023, 11:05
  > Done.

    Reply by Sean Nash on 07 March 2023, 11:16
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/Reservoirs.h
Revision Comment by Sean Nash on 07 March 2023, 11:15 
https://devapps.diality.us/cru/DG-DEN-14834-2#c16601

  Where did this go?

  Reply by Dara Navaei on 07 March 2023, 11:15
  > In common.h to be used by both stacks.

    Reply by Sean Nash on 07 March 2023, 11:18
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: Common.h
Revision Comment by Sean Nash on 06 March 2023, 17:10 
https://devapps.diality.us/cru/DG-DEN-14834-2#c16595

  Remove blank line.

  Reply by Dara Navaei on 07 March 2023, 11:03
  > Done

    Reply by Sean Nash on 07 March 2023, 11:19
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14834-2 https://devapps.diality.us/cru/DG-DEN-14834-2

Title: DG-DEN-14834_RO Flow Drops TO Zero And CP Measured Speed 1500 Temporarily During Pre Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Darren Cox
     jtaylor
     Steve Jarpe