This is a list of all comments for DG-DEN-14859-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeChemicalDisinfect.c
Revision Comment by Michael Garthwaite on 27 February 2023, 14:07 
https://devapps.diality.us/cru/DG-DEN-14859-1#c16543

  This variable is assigned twice in this init function

  Reply by Dara Navaei on 27 February 2023, 14:53
  > Removed one. Thanks.

    Reply by Michael Garthwaite on 27 February 2023, 14:54
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeFlush.c
Revision Comment by Michael Garthwaite on 27 February 2023, 14:00 
https://devapps.diality.us/cru/DG-DEN-14859-1#c16538

  rsrvrFillStableTimeCounter is no longer used in
  getRsrvrDrainStatus()

  Reply by Dara Navaei on 27 February 2023, 14:05
  > Removed the variables.

    Reply by Michael Garthwaite on 27 February 2023, 14:06
    > RESOVLED IN CODE WALKTHROUGH.

      Reply by Dara Navaei on 18 October 2023, 20:39
      > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeHeatDisinfect.c
Revision Comment by Michael Garthwaite on 27 February 2023, 13:58 
https://devapps.diality.us/cru/DG-DEN-14859-1#c16537

  targetDisinfectTime is only used in publishing. Documentation
  says its used in getHeatDisinfectStatus but its not used. Is it
  still needed?

  Reply by Dara Navaei on 27 February 2023, 14:03
  > I removed the variable from the documentation.

    Reply by Michael Garthwaite on 27 February 2023, 14:05
    > RESOVLED IN CODE WALKTHROUGH.

      Reply by Dara Navaei on 18 October 2023, 20:40
      > RESOLVED IN CODE WALKTHROUGH


---

ID: DG-DEN-14859-1 https://devapps.diality.us/cru/DG-DEN-14859-1

Title: DG-DEN-14859_Cleaning Modes State Timer Reset
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Michael Garthwaite   (*)
     wbracken   (*)
     Sean Nash
     Darren Cox
     jtaylor
     Steve Jarpe