This is a list of all comments for DG-DEN-15016-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by Sean Nash on 30 March 2023, 14:26 
https://devapps.diality.us/cru/DG-DEN-15016-1#c16999

  No need to increase this one.

  Reply by jtaylor on 31 March 2023, 08:22
  > Reverted.

    Reply by Sean Nash on 31 March 2023, 13:19
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 31 March 2023, 10:06 
https://devapps.diality.us/cru/DG-DEN-15016-1#c17022

  Space between ((

  Reply by jtaylor on 31 March 2023, 12:29
  > Done.

    Reply by wbracken on 31 March 2023, 12:53
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 30 March 2023, 18:56 
https://devapps.diality.us/cru/DG-DEN-15016-1#c17005

  I think it's better to end the if not POST body after the
  retries decrement (so don't use up retry during post, but still
  resend msg).

  Reply by jtaylor on 31 March 2023, 08:35
  > Done

    Reply by Sean Nash on 31 March 2023, 13:19
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 30 March 2023, 18:58 
https://devapps.diality.us/cru/DG-DEN-15016-1#c17006

  I think if HD not communicating, just clear the pending ack
  list - when HD revives, any pending messages in here are likely
  moot.

  Reply by jtaylor on 31 March 2023, 08:35
  > Done. Does HD communicating always account for UI traffic as
  > well?

    Reply by Sean Nash on 31 March 2023, 13:19
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-15016-1 https://devapps.diality.us/cru/DG-DEN-15016-1

Title: DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
Statement of Objectives:


State: Closed

Summary: 

Author: jtaylor
Moderator: jtaylor
Reviewers: (2 active, 4 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     wbracken   (*)
     Darren Cox   (*)
     Dara Navaei
     Steve Jarpe