This is a list of all comments for DG-DEN-15166-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/DrainPump.c
Revision Comment by Sean Nash on 18 April 2023, 08:17 
https://devapps.diality.us/cru/DG-DEN-15166-1#c17127

  Why remove?

  Reply by Dara Navaei on 18 April 2023, 08:31
  > Yes we do not support Beta in release.

    Reply by Sean Nash on 18 April 2023, 11:28
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by jtaylor on 18 April 2023, 08:22 
https://devapps.diality.us/cru/DG-DEN-15166-1#c17128

  Why call this "isRPMTooHigh" but compare the rpm against the
  "MIN_DRAIN_PUMP_RPM"?  Between MIN and MAX would be the natural
  valid range, similar to "isRPMOutOfRange", below.

  Reply by Dara Navaei on 18 April 2023, 08:33
  > This is in the Off state in which RPM being too high occurs
  > when the RPM is greater than the minimum RPM which is 300.

    Reply by jtaylor on 18 April 2023, 12:26
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Sean Nash on 18 April 2023, 08:24 
https://devapps.diality.us/cru/DG-DEN-15166-1#c17129

  Yes, fault.

  Reply by Dara Navaei on 18 April 2023, 08:32
  > Done

    Reply by Sean Nash on 18 April 2023, 11:25
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 18 April 2023, 08:25 
https://devapps.diality.us/cru/DG-DEN-15166-1#c17130

  Needs default or just do if/else.

  Reply by Dara Navaei on 18 April 2023, 08:34
  > Done

    Reply by Sean Nash on 18 April 2023, 11:25
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 18 April 2023, 08:26 
https://devapps.diality.us/cru/DG-DEN-15166-1#c17131

  Needs default or just do if/else.

  Reply by Dara Navaei on 18 April 2023, 08:35
  > Done

    Reply by Sean Nash on 18 April 2023, 11:25
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Thermistors.c
Revision Comment by Sean Nash on 18 April 2023, 08:28 
https://devapps.diality.us/cru/DG-DEN-15166-1#c17132

  Looks like we will not read ADC channels at all if release
  build.

  Reply by Dara Navaei on 18 April 2023, 08:37
  > Done

    Reply by Sean Nash on 18 April 2023, 11:24
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 18 April 2023, 08:31 
https://devapps.diality.us/cru/DG-DEN-15166-1#c17133

  request will remain if inlet alarms active.  is that what we
  want?

  Reply by Dara Navaei on 18 April 2023, 10:05
  > Please check the code again.

    Reply by Sean Nash on 18 April 2023, 11:23
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-15166-1 https://devapps.diality.us/cru/DG-DEN-15166-1

Title: DG-DEN-15166_Add Drain Pump Maxon Board RPM
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (5 active, 1 completed*)
     jtaylor   (*)
     Sean Nash
     Michael Garthwaite
     wbracken
     Darren Cox
     Steve Jarpe