This is a list of all comments for DG-DEN-15246-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeGenIdle.c
Revision Comment by wbracken on 02 May 2023, 13:21 
https://devapps.diality.us/cru/DG-DEN-15246-1#c17299

  Update header.

  Reply by Dara Navaei on 11 May 2023, 14:13
  > Done

    Reply by wbracken on 11 May 2023, 16:36
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Controllers/ConductivitySensors.c
Revision Comment by Sean Nash on 04 May 2023, 08:17 
https://devapps.diality.us/cru/DG-DEN-15246-1#c17319

  This function could, in theory, be used to assign a CD2 cal
  table to CPo (for example).

  Reply by Dara Navaei on 11 May 2023, 14:12
  > Is this a big risk? At this time I am not too concerned about
  > it. If you think it should be addressed, I can make changes.

    Reply by Sean Nash on 11 May 2023, 17:18
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 04 May 2023, 08:24 
https://devapps.diality.us/cru/DG-DEN-15246-1#c17320

  Add blank line before return statement.

  Reply by Dara Navaei on 11 May 2023, 13:57
  > Done

    Reply by Sean Nash on 11 May 2023, 17:18
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by Sean Nash on 04 May 2023, 08:28 
https://devapps.diality.us/cru/DG-DEN-15246-1#c17321

  Probably not needed, but for good measure can we do this in
  transition to GenIdle mode too?

  Reply by Dara Navaei on 11 May 2023, 13:56
  > Done

    Reply by Sean Nash on 11 May 2023, 17:19
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmtSWFaults.h
Revision Comment by Sean Nash on 04 May 2023, 08:29 
https://devapps.diality.us/cru/DG-DEN-15246-1#c17322

  This looks like 104.

  Reply by Dara Navaei on 11 May 2023, 13:53
  > This is 105.

    Reply by Sean Nash on 11 May 2023, 17:21
    > Then the one above with 100 comment is wrong.

      Reply by Dara Navaei on 11 May 2023, 17:33
      > Done

        Reply by Sean Nash on 11 May 2023, 19:50
        > Keep going.  Now 95 is wrong.  Need comments to align
        > with actual values throughout.

          Reply by Dara Navaei on 11 May 2023, 21:30
          > Done

          Reply by Sean Nash on 12 May 2023, 08:29
          > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-15246-1 https://devapps.diality.us/cru/DG-DEN-15246-1

Title: DG-DEN-15246_Active Reservoir Empty Post Concentrate Alarm Recovery
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Darren Cox
     jtaylor
     Steve Jarpe