DG-DEN-15274-1 DG-DEN-15274_HD DG Test Configuration Setup

closed on 17 May 23

Author

Moderator

Reviewers

DG-DEN-15274_HD DG Test Configuration Setup

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 24

dgfirmware 0
- Folder firmware/App 0
  - Folder Controllers 0
    - File ConductivitySensors.c 0 Remove
    - File ConductivitySensors.h 0 Remove
    - File Heaters.c 7 Remove
    - File LoadCell.c 6 Remove
    - File LoadCell.h 0 Remove
    - File TemperatureSensors.c 0 Remove
  - Folder Modes 0
    - File ModeChemicalDisinfect.c 0 Remove
    - File ModeChemicalDisinfectFlush.c 0 Remove
    - File ModeDrain.c 0 Remove
    - File ModeFill.c 6 Remove
    - File ModeFlush.c 0 Remove
    - File ModeGenIdle.c 6 Remove
    - File ModeGenIdle.h 3 Remove
    - File ModeHeatDisinfect.c 0 Remove
    - File ModeHeatDisinfectActiveCool.c 0 Remove
  - Folder Services 0
    - File Reservoirs.c 5 Remove
    - File Reservoirs.h 3 Remove
    - File SystemComm.c 0 Remove
    - File SystemCommMessages.c 3 Remove
    - File SystemCommMessages.h 0 Remove
fwcommon 0
- File NVDataMgmt.c 0 Remove
- File NVDataMgmtHDRecords.h 3 Remove
- File TestSupport.c 3 Remove
- File TestSupport.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author & Moderator	39m	15	Done.
Sean Nash	Reviewer - Complete	1h 48m	23	RESOLVED in CODE WALKTHROUGH.
Michael Garthwaite	Reviewer - 0% reviewed
wbracken (deleted user)	Reviewer - Complete	45m	10	RESOLVED IN CODE WALKTHROUGH
jtaylor (deleted user)	Reviewer - 100% reviewed	48m
Darren Cox	Reviewer - 0% reviewed	0m
Steve Jarpe	Reviewer - 0% reviewed
Total		4h 2m	48

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Sean Nash

Don't forget to roll compatibility for all 3 stacks.

16 May 23

Sean Nash

Resolved

17 May 23

Dara Navaei

Done.

17 May 23

Sean Nash

RESOLVED in CODE WALKTHROUGH.

17 May 23

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DG-DEN-15274-1

DG-DEN-15274_HD DG Test Configuration Setup

DG-DEN-15274-1 48

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Sean Nash

Dara Navaei

Sean Nash

Log time

DG-DEN-15274_HD DG Test Configuration Setup

DG-DEN-15274-1 48

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Sean Nash

Dara Navaei

Sean Nash

Log time