This is a list of all comments for DG-DEN-15274-1. Review Summary: No summary General Comment by Sean Nash on 16 May 2023, 15:37 https://devapps.diality.us/cru/DG-DEN-15274-1#c17606 Don't forget to roll compatibility for all 3 stacks. General Comment by Dara Navaei on 17 May 2023, 08:54 https://devapps.diality.us/cru/DG-DEN-15274-1#c17631 Done. Reply by Sean Nash on 17 May 2023, 09:25 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/LoadCell.c Revision Comment by Sean Nash on 17 May 2023, 08:30 https://devapps.diality.us/cru/DG-DEN-15274-1#c17627 If these are only for Dialin, move down to test support functions area. Reply by Dara Navaei on 17 May 2023, 08:34 > Done Reply by Sean Nash on 17 May 2023, 08:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 May 2023, 08:35 https://devapps.diality.us/cru/DG-DEN-15274-1#c17372 loadcells[] is an output in this function. Reply by Dara Navaei on 14 May 2023, 16:42 > Done Reply by Sean Nash on 14 May 2023, 16:45 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeFill.c Revision Comment by Sean Nash on 12 May 2023, 08:38 https://devapps.diality.us/cru/DG-DEN-15274-1#c17373 Should be != TRUE? Reply by Dara Navaei on 14 May 2023, 12:55 > Done Reply by Sean Nash on 14 May 2023, 16:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 15:48 https://devapps.diality.us/cru/DG-DEN-15274-1#c17473 Let's put test config conditions last when mixing with normal conditions (both ifs). Reply by Dara Navaei on 14 May 2023, 16:39 > Done Reply by Sean Nash on 14 May 2023, 16:45 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/Reservoirs.c Revision Comment by Sean Nash on 16 May 2023, 09:04 https://devapps.diality.us/cru/DG-DEN-15274-1#c17588 What is the purpose of the gain/offset? They seem pretty small and are dwarfed by the 2 deg extra offset we're adding. Reply by Sean Nash on 17 May 2023, 08:37 > Purpose is to account for cooling of dialysate from reservoir > to dialyzer. The faster Qd is, the less cooling will occur > (less time to cool). > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 16 May 2023, 10:38 https://devapps.diality.us/cru/DG-DEN-15274-1#c17592 This looks wrong. Reply by Dara Navaei on 16 May 2023, 17:16 > Done Reply by Sean Nash on 17 May 2023, 08:11 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by Sean Nash on 12 May 2023, 09:29 https://devapps.diality.us/cru/DG-DEN-15274-1#c17374 Declarations before code. Reply by Dara Navaei on 14 May 2023, 12:57 > Done Reply by Sean Nash on 14 May 2023, 16:43 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/Reservoirs.h Revision Comment by wbracken on 14 May 2023, 11:23 https://devapps.diality.us/cru/DG-DEN-15274-1#c17444 Extra blank line. Reply by Dara Navaei on 14 May 2023, 16:39 > Done Reply by wbracken on 14 May 2023, 19:34 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: NVDataMgmtHDRecords.h Revision Comment by wbracken on 13 May 2023, 11:30 https://devapps.diality.us/cru/DG-DEN-15274-1#c17442 Are these TODOs going to be removed? Reply by Dara Navaei on 14 May 2023, 16:40 > Yes eventually! Reply by wbracken on 14 May 2023, 19:35 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/Heaters.c Revision Comment by wbracken on 16 May 2023, 10:52 https://devapps.diality.us/cru/DG-DEN-15274-1#c17593 Remove (U32) cast. Reply by Dara Navaei on 16 May 2023, 17:16 > Done Reply by wbracken on 16 May 2023, 17:49 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 16 May 2023, 10:53 https://devapps.diality.us/cru/DG-DEN-15274-1#c17594 Remove (U32) cast. Reply by Sean Nash on 16 May 2023, 13:27 > function wants a U32. C will convert automatically, so not > necessary I guess. Reply by Dara Navaei on 16 May 2023, 17:15 > Done Reply by wbracken on 16 May 2023, 17:49 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModeGenIdle.c Revision Comment by Sean Nash on 14 May 2023, 16:39 https://devapps.diality.us/cru/DG-DEN-15274-1#c17477 Remove comment? Reply by Dara Navaei on 14 May 2023, 16:42 > Done Reply by Sean Nash on 14 May 2023, 16:44 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 16:39 https://devapps.diality.us/cru/DG-DEN-15274-1#c17479 Remove blank line? Reply by Dara Navaei on 14 May 2023, 16:42 > Done Reply by Sean Nash on 14 May 2023, 16:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeGenIdle.h Revision Comment by wbracken on 14 May 2023, 11:22 https://devapps.diality.us/cru/DG-DEN-15274-1#c17443 Comment for function. Reply by Dara Navaei on 14 May 2023, 16:40 > Done Reply by wbracken on 14 May 2023, 19:33 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: TestSupport.c Revision Comment by Sean Nash on 14 May 2023, 16:31 https://devapps.diality.us/cru/DG-DEN-15274-1#c17475 Disagree with comment change. Reply by Dara Navaei on 14 May 2023, 16:37 > Fixed it. Reply by Sean Nash on 14 May 2023, 16:43 > RESOLVED in CODE WALKTHROUGH. --- ID: DG-DEN-15274-1 https://devapps.diality.us/cru/DG-DEN-15274-1 Title: DG-DEN-15274_HD DG Test Configuration Setup Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (4 active, 2 completed*) Sean Nash (*) wbracken (*) Michael Garthwaite Darren Cox jtaylor Steve Jarpe