This is a list of all comments for DG-DEN-15367-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Sean Nash on 12 June 2023, 13:59 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17814

  Cycle is mis-spelled.

  Reply by Dara Navaei on 13 June 2023, 09:25
  > Done

    Reply by Sean Nash on 13 June 2023, 12:46
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 13 June 2023, 09:37 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17839

  Remove "handle" from this function name.  It should start with
  "send".  And why does this message have a payload.  Message
  itself infers ready.

  Reply by Dara Navaei on 13 June 2023, 10:27
  > Done

    Reply by Sean Nash on 13 June 2023, 12:48
    > Still has a payload.  Should remove it.

      Reply by Dara Navaei on 13 June 2023, 15:31
      > Done

        Reply by Sean Nash on 14 June 2023, 09:05
        > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 June 2023, 14:43 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17825

  We're always ready?  Why does UI need to ask if DG is ready if
  always ready?
  Replace "1" with "TRUE".

  Reply by Dara Navaei on 13 June 2023, 09:21
  > Changed to TRUE. Yes this message is only dispatched when DG
  > has finished dispensing and is sending HD a message that it
  > is ready to process another dispense or cancel command.

    Reply by Sean Nash on 13 June 2023, 09:37
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by wbracken on 12 June 2023, 01:01 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17776

  Update function header

  Reply by Dara Navaei on 13 June 2023, 09:34
  > This function will be overhauled.

    Reply by wbracken on 13 June 2023, 11:37
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 12 June 2023, 01:03 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17777

  Update function header.

  Reply by Dara Navaei on 13 June 2023, 09:33
  > Done

    Reply by wbracken on 13 June 2023, 11:39
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 12 June 2023, 01:03 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17778

  Update function header.

  Reply by Dara Navaei on 13 June 2023, 09:33
  > Done

    Reply by wbracken on 13 June 2023, 11:38
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 12 June 2023, 01:03 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17779

  Update function header.

  Reply by Dara Navaei on 13 June 2023, 09:32
  > Done

    Reply by wbracken on 13 June 2023, 11:38
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeROPermeateSample.c
Revision Comment by Sean Nash on 12 June 2023, 14:38 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17823

  Should default be separate from DISPENSING?  And should default
  have a s/w fault?

  Reply by Dara Navaei on 13 June 2023, 09:24
  > This function is only to set the actuators. If the incorrect
  > message status is selected the collect sample function will
  > trigger the software fault.

    Reply by Sean Nash on 13 June 2023, 12:46
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 June 2023, 14:39 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17824

  Should this be a s/w fault?

  Reply by Dara Navaei on 13 June 2023, 09:23
  > This is the lower level function to set the actuators. If the
  > state is incorrect the state machine in the exec function
  > will trigger the software fault.

    Reply by Sean Nash on 13 June 2023, 12:47
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: AlarmDefs.h
Revision Comment by Sean Nash on 30 May 2023, 08:34 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17673

  Fix alignment.

  Reply by Dara Navaei on 11 June 2023, 12:39
  > Done

    Reply by Sean Nash on 12 June 2023, 14:47
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: HDDefs.h
Revision Comment by wbracken on 06 June 2023, 13:14 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17762

  Comments.

  Reply by Dara Navaei on 11 June 2023, 12:43
  > Done

    Reply by wbracken on 12 June 2023, 00:55
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.c
Revision Comment by Sean Nash on 12 June 2023, 13:52 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17812

  Not really "off".  Should be applied when going slowly (<10
  mL/min).

  Reply by Dara Navaei on 13 June 2023, 09:27
  > Done

    Reply by Sean Nash on 13 June 2023, 12:50
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 June 2023, 13:54 
https://devapps.diality.us/cru/DG-DEN-15367-1#c17813

  The check against nearly zero is pointless since we're looking
  for > 10 mL/min now.
  Is cpTargetSpeed always positive (even when in reverse)?  If
  not, should absolute value speed before checking against low
  speed threshold.

  Reply by Dara Navaei on 13 June 2023, 12:40
  > Removed the check to make sure the target speed is > 0. The
  > current speed is always >= 0.0 mL/min.

    Reply by Sean Nash on 13 June 2023, 12:50
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-15367-1 https://devapps.diality.us/cru/DG-DEN-15367-1

Title: DG-DEN-15367_HD DG Test Configuration Setup
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (5 active, 1 completed*)
     Sean Nash   (*)
     Michael Garthwaite
     wbracken
     Darren Cox
     jtaylor
     Steve Jarpe