This is a list of all comments for DG-DEN-15634-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeDrain.c
Revision Comment by wbracken on 07 August 2023, 18:04 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18464

  Align comment

  Reply by Michael Garthwaite on 08 August 2023, 10:25
  > Fixed. Thanks!

    Reply by wbracken on 08 August 2023, 10:38
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 08 August 2023, 10:35 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18478

  Add blank line before function header.

  Reply by Michael Garthwaite on 08 August 2023, 13:14
  > Fixed. Thanks!

    Reply by Sean Nash on 09 August 2023, 15:03
    > Move blank line down one.

      Reply by Sean Nash on 09 August 2023, 15:07
      > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 07 August 2023, 18:05 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18465

  Add dataPublishCounter to header

  Reply by Michael Garthwaite on 08 August 2023, 10:25
  > Fixed. Thanks!

    Reply by wbracken on 08 August 2023, 10:38
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 07 August 2023, 18:06 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18466

  Update header

  Reply by Michael Garthwaite on 08 August 2023, 10:25
  > Fixed. Thanks!

    Reply by wbracken on 08 August 2023, 10:37
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 08 August 2023, 10:42 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18483

  Where is this function being called?

  Reply by Michael Garthwaite on 08 August 2023, 13:15
  > Missed calling it in the exec function. Good catch. fixed.

    Reply by Sean Nash on 09 August 2023, 15:04
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 07 August 2023, 18:09 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18468

  These 3 variables are not referenced

  Reply by Michael Garthwaite on 08 August 2023, 10:25
  > Fixed. Thanks!

    Reply by wbracken on 08 August 2023, 10:36
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeDrain.h
Revision Comment by Sean Nash on 08 August 2023, 10:45 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18485

  Restore blank line below separator comment.

  Reply by Michael Garthwaite on 08 August 2023, 13:14
  > Fixed. Thanks!

    Reply by Sean Nash on 09 August 2023, 15:05
    > Move blank line up one.

      Reply by Michael Garthwaite on 09 August 2023, 16:22
      > Fixed!

        Reply by Sean Nash on 09 August 2023, 17:25
        > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 08 August 2023, 10:45 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18484

  Add blank line before separator comment.

  Reply by Michael Garthwaite on 08 August 2023, 13:14
  > Fixed. Thanks!

    Reply by Sean Nash on 09 August 2023, 15:05
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by wbracken on 07 August 2023, 18:07 
https://devapps.diality.us/cru/DG-DEN-15634-1#c18467

  Add dataPublishCounter

  Reply by Michael Garthwaite on 08 August 2023, 13:35
  > Fixed. Thanks!

    Reply by wbracken on 09 August 2023, 13:43
    > RESOLVED IN CODE WALKTHROUGH


---

ID: DG-DEN-15634-1 https://devapps.diality.us/cru/DG-DEN-15634-1

Title: DG-DEN-15634_Bad Fill States And Signal Updating Inconsistently
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe