This is a list of all comments for DG-DEN-15660-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/TemperatureSensors.c
Revision Comment by Sean Nash on 10 July 2023, 17:20 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18030

  Don't like "timeout" in this constant.  It's not really a
  timeout.  It's a sample time (or collection time if you
  prefer).  Change TIMEOUT to TIME.

  Reply by Dara Navaei on 12 July 2023, 08:51
  > Done

    Reply by Sean Nash on 12 July 2023, 10:49
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 10 July 2023, 17:22 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18031

  Swap first and TRo positions in enum.  TRo should be first,
  then we add a first to mark it as first.

  Reply by Dara Navaei on 12 July 2023, 08:49
  > Done

    Reply by Sean Nash on 12 July 2023, 10:50
    > TRo needs comment for doxygen.

      Reply by Sean Nash on 12 July 2023, 15:44
      > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 10 July 2023, 17:34 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18032

  Do we still want un-averaged TDi and TRo in this broadcast?  Is
  anybody using them?  If not, why not replace the old temps with
  the new averages?

  Reply by Dara Navaei on 12 July 2023, 08:46
  > The un-averaged TDi and TRo are used for dialysate
  > temperature checking and trimmer heater control I think we
  > should keep them to be able to have a full picture if needed
  > unless the CAN bus is really flooded.

    Reply by Sean Nash on 12 July 2023, 10:53
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeChemicalDisinfect.c
Revision Comment by Sean Nash on 10 July 2023, 17:37 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18033

  Is this really a timeout?  Or is it a minimum duration?

  Reply by Dara Navaei on 12 July 2023, 08:44
  > This is a time and not timeout.

    Reply by Sean Nash on 12 July 2023, 10:51
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 10 July 2023, 17:37 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18034

  Replace "TIMEOUT" with "TIME"

  Reply by Dara Navaei on 12 July 2023, 08:42
  > Done

    Reply by Sean Nash on 12 July 2023, 10:51
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 10 July 2023, 17:56 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18035

  Can we move these declarations up to top of scope?

  Reply by Dara Navaei on 12 July 2023, 08:41
  > Done

    Reply by Sean Nash on 12 July 2023, 10:52
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 26 June 2023, 14:03 
https://devapps.diality.us/cru/DG-DEN-15660-1#c17999

  Add nelsonSupport, stateTrialCounter to header.

  Reply by Dara Navaei on 12 July 2023, 09:58
  > Nelson is not part of the commercial code.

    Reply by wbracken on 12 July 2023, 13:26
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 26 June 2023, 14:04 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18000

  Add stateTrialCounter

  Reply by Dara Navaei on 12 July 2023, 09:57
  > Done

    Reply by wbracken on 12 July 2023, 13:27
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 26 June 2023, 14:06 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18001

  Update header: rsrvr2Status, isRsrveLeadking,
  chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget,
  ischemDisinfectWarmupTargetReached (should be
  isChemDisinfectWarmupTargetReached).

  Reply by Dara Navaei on 12 July 2023, 09:08
  > Done

    Reply by wbracken on 12 July 2023, 13:32
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 26 June 2023, 14:09 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18002

  Update header.

  Reply by Dara Navaei on 12 July 2023, 09:06
  > Done

    Reply by wbracken on 12 July 2023, 13:27
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 26 June 2023, 14:10 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18003

  Add nelsonSupport

  Reply by Dara Navaei on 12 July 2023, 08:52
  > Nelson support is only in debug mode.

    Reply by wbracken on 12 July 2023, 13:28
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by Sean Nash on 11 July 2023, 09:05 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18036

  This looks strange.  If we have a empty bottle alarm, shouldn't
  we just not start a fill in the first place?  
  With this approach, you're just stuck in fill start state until
  user clears the alarm.

  Reply by Sean Nash on 12 July 2023, 10:53
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 11 July 2023, 09:08 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18037

  What about acid?

  Reply by Dara Navaei on 12 July 2023, 08:39
  > Done

    Reply by Sean Nash on 12 July 2023, 10:48
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeGenIdle.c
Revision Comment by wbracken on 11 July 2023, 17:30 
https://devapps.diality.us/cru/DG-DEN-15660-1#c18042

  handleEmptyBottleFlag is only an input

  Reply by Dara Navaei on 12 July 2023, 08:39
  > Done

    Reply by wbracken on 12 July 2023, 13:30
    > RESOLVED IN CODE WALKTHROUGH


---

ID: DG-DEN-15660-1 https://devapps.diality.us/cru/DG-DEN-15660-1

Title: DG-DEN-15660_Test Configuration Treatment Recovery
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (5 active, 1 completed*)
     Sean Nash   (*)
     Michael Garthwaite
     wbracken
     Darren Cox
     jtaylor
     Steve Jarpe