This is a list of all comments for DG-DEN-15683-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.c
Revision Comment by Sean Nash on 21 June 2023, 09:56 
https://devapps.diality.us/cru/DG-DEN-15683-1#c17949

  Why have {} in cases?

  Reply by wbracken on 21 June 2023, 11:10
  > Removed

    Reply by Sean Nash on 22 June 2023, 08:41
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 21 June 2023, 09:56 
https://devapps.diality.us/cru/DG-DEN-15683-1#c17950

  Add comment that other cases are ignored because loop makes
  them impossible.

  Reply by wbracken on 21 June 2023, 11:07
  > Done

    Reply by Sean Nash on 22 June 2023, 08:41
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 21 June 2023, 09:59 
https://devapps.diality.us/cru/DG-DEN-15683-1#c17951

  Declarations should be at top of scope.

  Reply by wbracken on 21 June 2023, 11:09
  > Done.

    Reply by Sean Nash on 22 June 2023, 08:41
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.h
Revision Comment by Sean Nash on 21 June 2023, 09:55 
https://devapps.diality.us/cru/DG-DEN-15683-1#c17948

  Comments are swapped.

  Reply by Sean Nash on 22 June 2023, 08:42
  > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-15683-1 https://devapps.diality.us/cru/DG-DEN-15683-1

Title: DG-DEN-15683_FW Alarm Handling OF Concentrate Pumps IS Incorrect
Statement of Objectives:


State: Closed

Summary: 

Author: wbracken
Moderator: wbracken
Reviewers: (3 active, 3 completed*)
     Sean Nash   (*)
     Darren Cox   (*)
     jtaylor   (*)
     Michael Garthwaite
     Dara Navaei
     Steve Jarpe