This is a list of all comments for DG-DEN-15702-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ConductivitySensors.c
Revision Comment by Sean Nash on 12 July 2023, 15:41 
https://devapps.diality.us/cru/DG-DEN-15702-1#c18087

  Remove gap before "=" as alignment no longer relevant.

  Reply by Darren Cox on 12 July 2023, 16:18
  > Corrected.

    Reply by Sean Nash on 13 July 2023, 13:09
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 11 July 2023, 17:41 
https://devapps.diality.us/cru/DG-DEN-15702-1#c18046

  Indentation needs to be corrected.

  Reply by Darren Cox on 12 July 2023, 16:18
  > Corrected.

    Reply by wbracken on 12 July 2023, 17:28
    > RESOLVED IN CODE REVIEW

----------------------------------------
File: firmware/App/Controllers/Pressures.c
Revision Comment by Sean Nash on 12 July 2023, 15:41 
https://devapps.diality.us/cru/DG-DEN-15702-1#c18086

  Remove gap before "=" as alignment no longer relevant.

  Reply by Darren Cox on 12 July 2023, 16:19
  > Corrected.

    Reply by Sean Nash on 13 July 2023, 13:09
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 11 July 2023, 17:42 
https://devapps.diality.us/cru/DG-DEN-15702-1#c18047

  Correct indentation

  Reply by Darren Cox on 12 July 2023, 16:18
  > Corrected.

    Reply by wbracken on 12 July 2023, 17:31
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Controllers/TemperatureSensors.c
Revision Comment by Sean Nash on 12 July 2023, 15:40 
https://devapps.diality.us/cru/DG-DEN-15702-1#c18085

  Remove gap before "=" as alignment no longer relevant.

  Reply by Darren Cox on 12 July 2023, 16:19
  > Corrected.

    Reply by Sean Nash on 13 July 2023, 13:09
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 11 July 2023, 17:42 
https://devapps.diality.us/cru/DG-DEN-15702-1#c18048

  Correct indentation

  Reply by Darren Cox on 12 July 2023, 16:19
  > Corrected.

    Reply by wbracken on 12 July 2023, 17:34
    > RESOLVED IN CODE WALKTHROUGH


---

ID: DG-DEN-15702-1 https://devapps.diality.us/cru/DG-DEN-15702-1

Title: DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     jtaylor   (*)
     Michael Garthwaite
     wbracken
     Dara Navaei
     Steve Jarpe