This is a list of all comments for DG-DEN-15842-1.

Review Summary: No summary


----------------------------------------
File: AlarmDefs.h
Revision Comment by Sean Nash on 20 July 2023, 15:34 
https://devapps.diality.us/cru/DG-DEN-15842-1#c18217

  Are we sure we want this?

  Reply by Darren Cox on 20 July 2023, 16:04
  > Blaine's comment shows discrepancy between HD and DG fan
  > handling with these flags.  Would we ever want to block an HD
  > Fan alarm?  Looks to indicate a HW fail.

    Reply by Sean Nash on 20 July 2023, 17:18
    > It's not a fault though.  User can choose to resume,
    > rinseback or end tx but will the alarm just trigger again
    > immediately if you haven't resolved the h/w problem?  With
    > the 2 properties set to TRUE, user can choose to rinseback
    > or end tx and they will not be bothered by this alarm again
    > until rinseback and post-tx are completed.

      Reply by Darren Cox on 27 July 2023, 14:02
      > I spoke with Blaine, he said make them consistent and
      > defer to Sean.  So they will both be as HD was - No
      > re-trigger in Rinseback or End TX.

        Reply by Dara Navaei on 27 July 2023, 14:57
        > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-15842-1 https://devapps.diality.us/cru/DG-DEN-15842-1

Title: DG-DEN-15842_Alarm 272 Fan Fault HD Alarm Does Not Declare During Post TX
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (4 active, 2 completed*)
     Dara Navaei   (*)
     jtaylor   (*)
     Sean Nash
     Michael Garthwaite
     wbracken
     Steve Jarpe