This is a list of all comments for DG-DEN-15973-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Sean Nash on 23 August 2023, 14:07 
https://devapps.diality.us/cru/DG-DEN-15973-1#c18704

  No point to having non-zero clear persistence - it's a fault.

  Reply by wbracken on 25 August 2023, 16:37
  > Corrected

    Reply by Sean Nash on 28 August 2023, 10:22
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Dara Navaei on 30 August 2023, 10:13 
https://devapps.diality.us/cru/DG-DEN-15973-1#c18769

  Please remove the blank line.

  Reply by wbracken on 01 September 2023, 13:36
  > Removed blank line

    Reply by Dara Navaei on 13 September 2023, 09:16
    > RESOLVED in CODE WALTHROUGH

Revision Comment by Sean Nash on 23 August 2023, 14:08 
https://devapps.diality.us/cru/DG-DEN-15973-1#c18706

  Put declarations at top of function.  Use our BOOL type.  Put
  ternary in ().

  Reply by wbracken on 25 August 2023, 16:36
  > Corrected

    Reply by Sean Nash on 28 August 2023, 10:20
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 23 August 2023, 14:13 
https://devapps.diality.us/cru/DG-DEN-15973-1#c18708

  Checking for alarm in this function means we will check when in
  control to flow or control to pressure states.  Also checked
  only once per control interval which is maybe ok, but not
  typical for alarm checks.
  We do control to flow for treatment modes.  Control to pressure
  is used in some cleaning modes.  Not sure we want this alarm
  enforced in cleaning modes.

  Reply by wbracken on 25 August 2023, 16:52
  > The  ROPump PWM is set from 5 different calls.  Doesn't look
  > like there is a global indicating the last set PWM value
  > (could add).  The execROPumpMonitor function might be a good
  > place to put the check as it looks to be able to  handle
  > different modes, but again doesn't have access to the last
  > set PWM value.

    Reply by Sean Nash on 01 September 2023, 12:28
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 23 August 2023, 14:09 
https://devapps.diality.us/cru/DG-DEN-15973-1#c18707

  Remove blank line.

  Reply by wbracken on 25 August 2023, 16:36
  > Corrected

    Reply by Sean Nash on 28 August 2023, 10:21
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Pressures.c
Revision Comment by Sean Nash on 08 September 2023, 13:06 
https://devapps.diality.us/cru/DG-DEN-15973-1#c18867

  Keep declarations at top of scope.  Just have assignments down
  here.

  Reply by wbracken on 08 September 2023, 13:31
  > Corrected

    Reply by Sean Nash on 08 September 2023, 16:43
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-15973-1 https://devapps.diality.us/cru/DG-DEN-15973-1

Title: DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: wbracken
Moderator: wbracken
Reviewers: (3 active, 3 completed*)
     Sean Nash   (*)
     Darren Cox   (*)
     jtaylor   (*)
     Michael Garthwaite
     Dara Navaei
     Steve Jarpe