This is a list of all comments for DG-DEN-16314-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by Sean Nash on 07 September 2023, 13:47 
https://devapps.diality.us/cru/DG-DEN-16314-1#c18858

  I don't see these being used anywhere.

  Reply by jtaylor on 07 September 2023, 15:35
  > Done.  Code updates pushed.

    Reply by Sean Nash on 08 September 2023, 09:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 September 2023, 16:22 
https://devapps.diality.us/cru/DG-DEN-16314-1#c18926

  You are removing recover treatment test config functionality?
  Is this moving somewhere else or we've decided not to
  implement?

  Reply by jtaylor on 15 September 2023, 15:54
  > Dara suggested removing this, as the feature was incomplete
  > and appears to cause odd timer/alarm behavior.

    Reply by Sean Nash on 15 September 2023, 16:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 08 September 2023, 13:19 
https://devapps.diality.us/cru/DG-DEN-16314-1#c18868

  Add blank line between this code and switch below.

  Reply by jtaylor on 08 September 2023, 13:28
  > Done.

    Reply by Sean Nash on 08 September 2023, 14:15
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/Reservoirs.h
Revision Comment by Dara Navaei on 08 September 2023, 09:06 
https://devapps.diality.us/cru/DG-DEN-16314-1#c18861

  Why are these fields removed?

  Reply by jtaylor on 08 September 2023, 09:49
  > These fields have been moved to a different broadcast at some
  > point, and were no longer being set by the reservoir data
  > broadcast.  The fields regularly contained "NAN" values, so I
  > removed them.

    Reply by Dara Navaei on 08 September 2023, 11:03
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-16314-1 https://devapps.diality.us/cru/DG-DEN-16314-1

Title: DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
Statement of Objectives:


State: Closed

Summary: 

Author: jtaylor
Moderator: jtaylor
Reviewers: (4 active, 3 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei   (*)
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     Darren Cox