This is a list of all comments for DG-DEN-16565-1.

Review Summary: No summary


----------------------------------------
File: firmware/.cproject
Revision Comment by Sean Nash on 02 January 2024, 14:14 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19339

  Needed?

----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by Sean Nash on 22 December 2023, 09:37 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19328

  Why aren't we calling the specific handlers for reboot and
  enter bootloader commands?

----------------------------------------
File: firmware/source/sys_link.cmd
Revision Comment by Vinayakam Mani on 24 May 2024, 11:59 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19780

  we need to take care of existing stack size while we merge the
  bootloader changes. the current stack size is 0x3400, not
  0x4C00.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.h
Revision Comment by Sean Nash on 02 January 2024, 14:07 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19330

  Why one handler for 3 commands?

----------------------------------------
File: firmware/source/sys_startup.c
Revision Comment by Sean Nash on 02 January 2024, 14:09 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19332

  This is not user code.  Next regen will restore this code.  Do
  we really need to disable ECC error handling?

Revision Comment by Sean Nash on 02 January 2024, 14:10 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19334

  Remove duplicate user code start comment.

Revision Comment by Sean Nash on 02 January 2024, 14:11 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19336

  What is this code doing?  Why no comments?  Is it necessary?

Revision Comment by Sean Nash on 02 January 2024, 14:11 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19335

  #if 1 and #endif appear to be unnecessary.  Remove.

Revision Comment by Sean Nash on 02 January 2024, 14:12 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19337

  This is not user code.  Next regen will restore this code.  Do
  we really need to remove this code?

Revision Comment by Sean Nash on 02 January 2024, 14:13 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19338

  This is not user code.  Next regen will restore this code.  Do
  we really need to disable ECC test code?

----------------------------------------
File: firmware/source/sys_mpu.asm
Revision Comment by Sean Nash on 02 January 2024, 14:08 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19331

  This is not user code.  Next regen will restore this code.  Do
  we really need to disable this?

----------------------------------------
File: MsgDefs.h
Revision Comment by Sean Nash on 06 June 2024, 10:46 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19785

  Can we get by with just 1 msg?  Add doxygen comments.

----------------------------------------
File: Integrity.c
Revision Comment by Sean Nash on 02 January 2024, 14:15 
https://devapps.diality.us/cru/DG-DEN-16565-1#c19340

  Is bootloader going to use fwcommon code?  Is #ifdef #else
  backwards?

  Reply by Sean Nash on 06 June 2024, 10:48
  > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-16565-1 https://devapps.diality.us/cru/DG-DEN-16565-1

Title: DG-DEN-16565_SW Updater HD DG App Side Intake From Sunrise
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (6 active, 0 completed*)
     Sean Nash
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     Darren Cox
     Dana Rich