This is a list of all comments for DG-DEN-16587-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeGenIdle.c
Revision Comment by Dara Navaei on 01 February 2024, 16:59 
https://devapps.diality.us/cru/DG-DEN-16587-1#c19371

  Please add the unit at the end of the #define

  Reply by Sean Nash on 05 February 2024, 13:40
  > Dara meant for you to add units to end of name (i.e.
  > MAX_IDLE_RSVR_WEIGHT_GAIN_ML).

    Reply by Dara Navaei on 06 February 2024, 12:32
    > RESOLVED in CODE WALKTHROUGH

Revision Comment by Sean Nash on 02 February 2024, 10:28 
https://devapps.diality.us/cru/DG-DEN-16587-1#c19393

  inactive misspelled in comment.

  Reply by Sean Nash on 05 February 2024, 13:40
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 10:32 
https://devapps.diality.us/cru/DG-DEN-16587-1#c19394

  Use 2 U32 Data macro and log initial weight as well.

  Reply by Sean Nash on 05 February 2024, 13:41
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 15 February 2024, 09:28 
https://devapps.diality.us/cru/DG-DEN-16587-1#c19467

  Why is this reservoir check only happening in this state?
  Recommend creating a separate function to perform the check and
  call that function from gen idle exec function (i.e. do check
  in all gen idle states).

  Reply by Darren Cox on 15 February 2024, 09:51
  > In pre-treat, there were transfers from one reservoir to the
  > other that caused a false alarm.  Figuring that out in SW at
  > this level seemed overly complex.  Also, the ticket notes
  > this problem in Treatment only.

    Reply by Sean Nash on 15 February 2024, 11:01
    > Question was in relation to DG gen idle sub-state, not HD
    > mode.

      Reply by Sean Nash on 15 February 2024, 12:52
      > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: AlarmDefs.h
Revision Comment by Dara Navaei on 01 February 2024, 16:35 
https://devapps.diality.us/cru/DG-DEN-16587-1#c19370

  This should be a fault alarm. Like the properties of alarm 189
  (drain pump RPM out of range)

  Reply by Dara Navaei on 06 February 2024, 12:36
  > RESOLVED in CODE WLAKTHROUGH

Revision Comment by Sean Nash on 02 February 2024, 10:27 
https://devapps.diality.us/cru/DG-DEN-16587-1#c19392

  This row needs to be updated.

  Reply by Sean Nash on 05 February 2024, 13:39
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Vinayakam Mani on 09 February 2024, 09:40 
https://devapps.diality.us/cru/DG-DEN-16587-1#c19459

  DG idle reservoir out of range - rewording " DG idle reservoir
  weight out of range" would be better?

  Reply by Darren Cox on 14 February 2024, 14:15
  > Updated.

    Reply by Vinayakam Mani on 14 February 2024, 14:37
    > RESOLVED IN CODE WALKTHROUGH.


---

ID: DG-DEN-16587-1 https://devapps.diality.us/cru/DG-DEN-16587-1

Title: DG-DEN-16587_Alarm 278 Rsvr Overfill Triggered During Treatment Reservoirs Filled TO 2000 ML
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     jpaguio
     Vinayakam Mani
     Michael Garthwaite