This is a list of all comments for DG-DEN-17135-1.

Review Summary: No summary


----------------------------------------
File: NVDataMgmt.c
Revision Comment by Sean Nash on 29 January 2025, 16:26 
https://devapps.diality.us/cru/DG-DEN-17135-1#c21276

  Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary?
  Seems like &concPump->concentratePumps[ i ] is already that
  type.

  Reply by Dara Navaei on 29 January 2025, 16:28
  > Removed the typecast.

    Reply by Sean Nash on 29 January 2025, 17:14
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: AlarmDefs.h
Revision Comment by Vinayakam Mani on 29 January 2025, 17:12 
https://devapps.diality.us/cru/DG-DEN-17135-1#c21289

  The Trigger condition is little confusing. could you please
  reword it? Also In title, do you want to add " fault", if it is
  DG fault property?

  Reply by Dara Navaei on 29 January 2025, 17:22
  > Updated the trigger condition. This is a calibration and is
  > checked in POST. The titles are POST.

    Reply by Vinayakam Mani on 29 January 2025, 17:32
    > RESOLVED IN CODE WALKTHROUGH


---

ID: DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1

Title: DG-DEN-17135_Concentrate Pump Calibration Staging
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Vinayakam Mani   (*)
     jpaguio
     Michael Garthwaite