This is a list of all comments for DG-DEN-2379-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/Heaters.c Revision Comment by Sean Nash on 20 May 2020, 09:27 https://devapps.diality.us/cru/DG-DEN-2379-1#c1970 Add module comment for doxygen. Reply by Dara Navaei on 20 May 2020, 12:54 > Done Reply by Sean Nash on 27 May 2020, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 31 May 2020, 19:23 https://devapps.diality.us/cru/DG-DEN-2379-1#c2134 FW code base is the wrong place to create an AE to do list. Reply by Dara Navaei on 01 June 2020, 10:16 > Done Reply by pmontazemi on 01 June 2020, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 31 May 2020, 19:23 https://devapps.diality.us/cru/DG-DEN-2379-1#c2135 What are these Us? Reply by Dara Navaei on 31 May 2020, 19:29 > I am sorry, I don't understand the question. Reply by pmontazemi on 31 May 2020, 19:34 > The U in 40U, 35U, what are the Us for? Are these units of > time? Are these UTC-based time stamps? Reply by Dara Navaei on 31 May 2020, 19:39 > No, these are unsigned values. For instance, the target > temperature is +40 C and it won't -40 C. Reply by pmontazemi on 31 May 2020, 19:45 > So, U16, U32, for variable types and 40U, 35U for > unsigned parameters? Is this following our C Code > Standard? Reply by Dara Navaei on 31 May 2020, 20:05 > I only use U in #defines since the type of defined > implicitly. For instance you can say #define coeff > 2.35 or #define temp 35. So for the integers if they > are unsigned, I put the U in the end. But when you > define a variable U16 a = 23, then U is not needed > because you explicitly define the type of the > variable to be a unsigned 16-bit integer. It is for > extra safety mostly. Reply by pmontazemi on 01 June 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:28 https://devapps.diality.us/cru/DG-DEN-2379-1#c1971 Remove redundant function names after brief in function headers. Reply by Sean Nash on 27 May 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:29 https://devapps.diality.us/cru/DG-DEN-2379-1#c1972 Output is that the module is initialized. Reply by Dara Navaei on 27 May 2020, 15:26 > Done Reply by Sean Nash on 28 May 2020, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:30 https://devapps.diality.us/cru/DG-DEN-2379-1#c1974 There is no inputs to this function. targetTemp is a @param. Reply by Dara Navaei on 27 May 2020, 15:23 > Done Reply by Sean Nash on 28 May 2020, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:30 https://devapps.diality.us/cru/DG-DEN-2379-1#c1976 Output is that primaryHeaterTargetTemperature is set to given temperature. Reply by Dara Navaei on 27 May 2020, 15:21 > Done Reply by Sean Nash on 28 May 2020, 10:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:31 https://devapps.diality.us/cru/DG-DEN-2379-1#c1977 Should be a @param. Reply by Sean Nash on 20 May 2020, 13:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:33 https://devapps.diality.us/cru/DG-DEN-2379-1#c1979 Input is primaryHeaterTargetTemperature and mainPrimaryHeaterDutyCycle. Reply by Dara Navaei on 27 May 2020, 15:18 > Done Reply by Sean Nash on 28 May 2020, 10:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:31 https://devapps.diality.us/cru/DG-DEN-2379-1#c1978 status is what is returned - not an output. Output is that heater state is reset, primary heater PWM is set, and we go to control to target state if target is non-zero. Reply by Dara Navaei on 27 May 2020, 15:18 > Done Reply by Sean Nash on 28 May 2020, 10:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:41 https://devapps.diality.us/cru/DG-DEN-2379-1#c1986 This function starts the heater immediately. I think it's better practice to have a command/request function like this set a pending request flag or something like that and then have the exec state machine (when it is next called) check the flag and handle the state transition. This gives the exec complete control of its state machine and allows it to make the determination of whether or not it will allow the transition. Same comment on stop and on start/stop functions for trimmer heater. Reply by Dara Navaei on 27 May 2020, 17:55 > Done Reply by Sean Nash on 28 May 2020, 10:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:35 https://devapps.diality.us/cru/DG-DEN-2379-1#c1981 Add blank lines between cases for consistency. Reply by Dara Navaei on 20 May 2020, 12:58 > Done Reply by Sean Nash on 28 May 2020, 10:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:36 https://devapps.diality.us/cru/DG-DEN-2379-1#c1982 Remove blank lines between case and code for consistency. Reply by Sean Nash on 20 May 2020, 13:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:49 https://devapps.diality.us/cru/DG-DEN-2379-1#c1993 Missing @param. Reply by Dara Navaei on 20 May 2020, 12:45 > Done Reply by Sean Nash on 20 May 2020, 13:14 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 29 May 2020, 09:09 https://devapps.diality.us/cru/DG-DEN-2379-1#c2117 If test code, add TODO to remember to either put it back in or remove it. Do this everywhere as a rule. Reply by Dara Navaei on 29 May 2020, 09:21 > I have TODO lines above and at the bottom of the test code > area. Please look at lines around #ifdef and #endif Reply by Dara Navaei on 19 October 2023, 08:36 > RESOLVED in CODE WALKTHROUGH Revision Comment by Sean Nash on 20 May 2020, 09:49 https://devapps.diality.us/cru/DG-DEN-2379-1#c1992 Missing @param. Reply by Dara Navaei on 20 May 2020, 12:45 > Done Reply by Sean Nash on 20 May 2020, 13:14 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:49 https://devapps.diality.us/cru/DG-DEN-2379-1#c1991 Missing @param. Reply by Dara Navaei on 20 May 2020, 12:46 > Done Reply by Sean Nash on 20 May 2020, 13:14 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:49 https://devapps.diality.us/cru/DG-DEN-2379-1#c1990 Missing @param Reply by Dara Navaei on 20 May 2020, 12:47 > Done Reply by Sean Nash on 20 May 2020, 13:14 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 23:08 https://devapps.diality.us/cru/DG-DEN-2379-1#c1935 1. inletTemperatrue? 2. Variable declared but never used? Reply by Dara Navaei on 20 May 2020, 12:47 > Removed the commented code Reply by pmontazemi on 20 May 2020, 13:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 29 May 2020, 09:09 https://devapps.diality.us/cru/DG-DEN-2379-1#c2116 If test code, add TODO to remember to either put it back in or remove it. Do this everywhere as a rule. Reply by Dara Navaei on 29 May 2020, 09:20 > I have TODO lines above and at the bottom of the test code > area. Please look at lines around #ifdef and #endif Reply by pmontazemi on 01 June 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 23:09 https://devapps.diality.us/cru/DG-DEN-2379-1#c1936 1. inletTemperatrue? 2. Variable declared but never used? Reply by Dara Navaei on 20 May 2020, 12:48 > Removed the commented code Reply by pmontazemi on 20 May 2020, 13:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:48 https://devapps.diality.us/cru/DG-DEN-2379-1#c1987 You have debug code to dump temperature data, but I don't see an actual broadcast on CAN. Reply by Dara Navaei on 29 May 2020, 15:02 > I added the CAN broadcast function. It will only broadcast > the PWM values. The temperature values will be broadcast in > TemperatureSensors module. Reply by Sean Nash on 01 June 2020, 10:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 27 May 2020, 10:17 https://devapps.diality.us/cru/DG-DEN-2379-1#c2055 Remove commented lines. Reply by Dara Navaei on 27 May 2020, 15:14 > Done Reply by pmontazemi on 28 May 2020, 11:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 23:09 https://devapps.diality.us/cru/DG-DEN-2379-1#c1937 #define constant Reply by Dara Navaei on 20 May 2020, 09:01 > This is temporary and will be removed. I am only reading flow > for testing in this module. Reply by pmontazemi on 20 May 2020, 13:10 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 23:10 https://devapps.diality.us/cru/DG-DEN-2379-1#c1938 Remove extra lines at OEF. Reply by Dara Navaei on 20 May 2020, 12:48 > Done Reply by pmontazemi on 20 May 2020, 13:10 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/TemperatureSensors.c Revision Comment by Sean Nash on 20 May 2020, 09:06 https://devapps.diality.us/cru/DG-DEN-2379-1#c1954 Should be private definitions. I see variables way down below the #defines and enumerations. Reply by Dara Navaei on 20 May 2020, 14:19 > Done Reply by Sean Nash on 28 May 2020, 10:59 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 03 June 2020, 14:48 https://devapps.diality.us/cru/DG-DEN-2379-1#c2176 Where did all these temperature coefficients go? Reply by Dara Navaei on 05 June 2020, 10:36 > They are all in the arrays at the bottom of the private > variables Reply by pmontazemi on 05 June 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:07 https://devapps.diality.us/cru/DG-DEN-2379-1#c1955 ///< comments should come at end of declaration. Reply by Dara Navaei on 27 May 2020, 16:04 > Done Reply by Sean Nash on 28 May 2020, 10:58 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:07 https://devapps.diality.us/cru/DG-DEN-2379-1#c1956 Missing comments. Reply by Dara Navaei on 27 May 2020, 16:07 > Done Reply by Sean Nash on 28 May 2020, 10:58 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:09 https://devapps.diality.us/cru/DG-DEN-2379-1#c1957 I know I started this, but I've been removing the redundant function name after "brief" in function headers. Reply by Dara Navaei on 20 May 2020, 14:15 > Done Reply by Sean Nash on 28 May 2020, 10:57 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:09 https://devapps.diality.us/cru/DG-DEN-2379-1#c1958 There are outputs in this function. Module is initialized. Reply by Dara Navaei on 27 May 2020, 16:02 > Done Reply by Sean Nash on 28 May 2020, 10:57 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 02 June 2020, 13:07 https://devapps.diality.us/cru/DG-DEN-2379-1#c2172 Please make sure to provide a command that can retrieve these parameters from Dialin API for FWV. Reply by Dara Navaei on 02 June 2020, 14:18 > For verification, the coefficients of the conversion > equations can be retrieved from the SDD. Reply by pmontazemi on 05 June 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:11 https://devapps.diality.us/cru/DG-DEN-2379-1#c1960 Add blank line between functions for consistency. Reply by Dara Navaei on 20 May 2020, 14:16 > Done Reply by Sean Nash on 28 May 2020, 10:57 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:10 https://devapps.diality.us/cru/DG-DEN-2379-1#c1959 Remove blank lines between case and code for consistency. Reply by Sean Nash on 27 May 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:12 https://devapps.diality.us/cru/DG-DEN-2379-1#c1961 Add blank line between declarations and function code for consistency. Reply by Dara Navaei on 27 May 2020, 15:58 > Done Reply by Sean Nash on 28 May 2020, 10:56 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 27 May 2020, 10:28 https://devapps.diality.us/cru/DG-DEN-2379-1#c2060 Remove commented out switch statement. Reply by Dara Navaei on 27 May 2020, 15:09 > Done Reply by Sean Nash on 28 May 2020, 10:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:16 https://devapps.diality.us/cru/DG-DEN-2379-1#c1963 I would consider breaking this large function into 3 smaller functions. One for this, one for converting heater temperatures, and one for converting other temperatures. Maybe even more for dealing with error flags, etc... Reply by Dara Navaei on 31 May 2020, 17:44 > Done. This function will be removed after testing. Reply by Sean Nash on 01 June 2020, 10:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:15 https://devapps.diality.us/cru/DG-DEN-2379-1#c1962 A comment explaining what you're doing here (sign extending a 14-bit value) would be helpful. Reply by Dara Navaei on 27 May 2020, 15:55 > Done Reply by Sean Nash on 28 May 2020, 10:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 June 2020, 12:00 https://devapps.diality.us/cru/DG-DEN-2379-1#c2169 Move this i declaration closer to where it's used (inside the if (CJTemp > 0) body). Reply by Dara Navaei on 05 June 2020, 10:33 > Done Reply by Sean Nash on 05 June 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:20 https://devapps.diality.us/cru/DG-DEN-2379-1#c1964 Seems like you could set this state in the exec switch statement instead of having a function do it. Reply by Dara Navaei on 27 May 2020, 17:30 > Yes, I created a function for this state for two reasons: 1. > To be consistent with the rest of the states 2. I think we > should create a delay for FPGA to read the data although I > added the delay in the exec state machine. This function will > be mostly used as a place holder. Reply by Dara Navaei on 19 October 2023, 08:38 > RESOLVED in CODE WALKTHROUGH Revision Comment by Sean Nash on 20 May 2020, 09:22 https://devapps.diality.us/cru/DG-DEN-2379-1#c1966 Should we just set this in initTemperatures() so we don't have to check for zero in this function? Reply by Dara Navaei on 27 May 2020, 15:32 > I zero this variable in initTemperatures(). I only check if > it is zero so I can get the and start counting. I have > created a delay before I go to getADCRead() state. Before I > go to the next state, I zero the variable to be used again. Reply by Sean Nash on 28 May 2020, 10:54 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:24 https://devapps.diality.us/cru/DG-DEN-2379-1#c1967 This seems unreachable. elapsedTime is set before coming to this state so it should never be zero. Reply by Dara Navaei on 27 May 2020, 15:48 > This is reachable, before I move to this state, I set this > variable to 0. Then for the first time it will be 0 and a > time is set. Once the time has elapsed, the inlet temperature > is checked and the variable is set to 0 for another round of > checking. Reply by Sean Nash on 28 May 2020, 10:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 June 2020, 12:08 https://devapps.diality.us/cru/DG-DEN-2379-1#c2171 sampleCount is a single running average sample counter but it looks like it's being used for multiple sensors. Doesn't look right. Reply by Dara Navaei on 03 June 2020, 09:00 > Done Reply by Dara Navaei on 19 October 2023, 08:38 > RESOLVED in CODE WALKTHROUGH Revision Comment by Sean Nash on 02 June 2020, 12:05 https://devapps.diality.us/cru/DG-DEN-2379-1#c2170 Since runningSum is an integer, consider changing sample count to a power-of-two value (e.g. 16 or 32) so you can replace this division with a right bit shift (much faster). Would mean your average would be low until your running average buffer is full of samples though. Reply by Dara Navaei on 03 June 2020, 09:00 > Done Reply by Sean Nash on 05 June 2020, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 29 May 2020, 13:28 https://devapps.diality.us/cru/DG-DEN-2379-1#c2121 Remove extra line. Reply by Dara Navaei on 29 May 2020, 14:59 > Done Reply by pmontazemi on 01 June 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 29 May 2020, 13:28 https://devapps.diality.us/cru/DG-DEN-2379-1#c2122 Remove Extra line. Reply by Dara Navaei on 29 May 2020, 14:58 > Done Reply by pmontazemi on 01 June 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.c Revision Comment by Sean Nash on 27 May 2020, 10:22 https://devapps.diality.us/cru/DG-DEN-2379-1#c2058 Need function headers. Reply by Dara Navaei on 27 May 2020, 15:13 > Sorry, I developed that for testing but it turned out that I > needed it. Added the headers Reply by Sean Nash on 28 May 2020, 10:45 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Heaters.h Revision Comment by Sean Nash on 20 May 2020, 09:26 https://devapps.diality.us/cru/DG-DEN-2379-1#c1968 Add module comment for doxygen. Reply by Dara Navaei on 27 May 2020, 15:31 > Done Reply by Sean Nash on 28 May 2020, 10:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 23:10 https://devapps.diality.us/cru/DG-DEN-2379-1#c1939 Where are the override functions? Reply by Dara Navaei on 29 May 2020, 15:00 > I have added the override functions for setting a temperature > value and also for changing the publish time. The rest of the > functions for setting target temperature and starting the > heaters will not be override functions. Reply by pmontazemi on 01 June 2020, 10:33 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/TemperatureSensors.h Revision Comment by Sean Nash on 20 May 2020, 09:26 https://devapps.diality.us/cru/DG-DEN-2379-1#c1969 Add module comment for doxygen. Reply by Sean Nash on 27 May 2020, 10:38 > Match other examples for format. Reply by Dara Navaei on 27 May 2020, 15:30 > Done Reply by Sean Nash on 28 May 2020, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 May 2020, 09:04 https://devapps.diality.us/cru/DG-DEN-2379-1#c1953 Put a /// comment above enumerations - provide general description of the enumeration. Reply by Dara Navaei on 27 May 2020, 15:30 > Done Reply by Sean Nash on 28 May 2020, 10:59 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 01 June 2020, 10:36 https://devapps.diality.us/cru/DG-DEN-2379-1#c2148 SENSOR instead of SESNOR. Reply by Dara Navaei on 01 June 2020, 10:41 > Done Reply by pmontazemi on 01 June 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 23:13 https://devapps.diality.us/cru/DG-DEN-2379-1#c1940 Override functions? Reply by Dara Navaei on 27 May 2020, 15:31 > I have added the override function Reply by pmontazemi on 28 May 2020, 11:02 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 31 May 2020, 15:34 https://devapps.diality.us/cru/DG-DEN-2379-1#c2129 I recommend not using Crucible as a notepad. AE activities should be done as part of the "Update Requirements" Sub-Task in Jira. Reply by Dara Navaei on 31 May 2020, 17:41 > I am not using AE as notepad, I am using my code as notepad. > The bulk of the AE documentation is done in the Sub-task but > as I am developing, more items need to be added/removed. I > always have todos next to them and once in a while I will > sweep through them. This was I can ensure that AE is in sync > with the firmware. Reply by Dara Navaei on 01 June 2020, 10:17 > Done Reply by pmontazemi on 01 June 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by pmontazemi on 19 May 2020, 23:20 https://devapps.diality.us/cru/DG-DEN-2379-1#c1944 Remove commented code. Reply by Dara Navaei on 27 May 2020, 16:09 > This part of code was not available in this branch. I > commented it, it will be added in the DG firmware > infrastructure branch. Reply by pmontazemi on 28 May 2020, 11:07 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Drivers/SafetyShutdown.h Revision Comment by pmontazemi on 19 May 2020, 23:13 https://devapps.diality.us/cru/DG-DEN-2379-1#c1941 Override functions? Reply by Dara Navaei on 27 May 2020, 16:10 > This module is beyond the scope of this branch. [~snash] > please respond. Reply by pmontazemi on 28 May 2020, 11:03 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by pmontazemi on 19 May 2020, 23:14 https://devapps.diality.us/cru/DG-DEN-2379-1#c1943 Where is ModeInitPOST.h? Reply by Dara Navaei on 20 May 2020, 09:01 > It didn't show up because we have not made any changes to it. Reply by pmontazemi on 20 May 2020, 13:12 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 23:14 https://devapps.diality.us/cru/DG-DEN-2379-1#c1942 Empty? Reply by Dara Navaei on 20 May 2020, 12:58 > This function will be filled up later. [~snash] please > respond Reply by pmontazemi on 20 May 2020, 13:11 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by Sean Nash on 01 June 2020, 10:36 https://devapps.diality.us/cru/DG-DEN-2379-1#c2147 Why did this change? Looks wrong. Reply by Dara Navaei on 01 June 2020, 10:51 > Done Reply by Sean Nash on 01 June 2020, 10:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 31 May 2020, 15:37 https://devapps.diality.us/cru/DG-DEN-2379-1#c2130 If this function must return "result", why is function void? Is result defined as a static for the entire module? Reply by pmontazemi on 01 June 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. --- ID: DG-DEN-2379-1 https://devapps.diality.us/cru/DG-DEN-2379-1 Title: DG-DEN-2379_DG Dialysate Temperature 1 of 2 Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (2 active, 0 completed*) Sean Nash pmontazemi