DG-DEN-3421_DG Heat Disinfection

Activity

DG-DEN-3421-2-1 158

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 3h 59m 54 Done
    Reviewer - Complete 2h 13m 50 Dara, it is misspelled.
    qnguyen  (deleted user)
    Reviewer completed
    Reviewer - Complete 2h 19m 32 RESOLVED in CODE WALKTHROUGH.
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 1h 26m 22 RESOLVED in CODE WALKTHROUGH.
    Total   9h 59m 158  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Controllers/DrainPump.c Changed 3
    Open in IDE #permalink
    /firmware/App/Controllers/DrainPump.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Fans.c Added 37
    Open in IDE #permalink
    /firmware/App/Controllers/Fans.h Added 3
    Open in IDE #permalink
    /firmware/App/Controllers/Heaters.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Heaters.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/ROPump.c Changed 9
    Open in IDE #permalink
    /firmware/App/Controllers/ROPump.h Changed
    Open in IDE #permalink
    /firmware/.../Controllers/TemperatureSensors.c Changed 20
    Open in IDE #permalink
    /firmware/.../Controllers/TemperatureSensors.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Thermistors.c Added 6
    Open in IDE #permalink
    /firmware/App/Controllers/Thermistors.h Added 3
    Open in IDE #permalink
    /firmware/App/Controllers/UVReactors.c Added 36
    Open in IDE #permalink
    /firmware/App/Controllers/UVReactors.h Added 6
    Open in IDE #permalink
    /firmware/App/Drivers/InternalADC.c Changed 3
    Open in IDE #permalink
    /firmware/App/Drivers/InternalADC.h Changed
    Open in IDE #permalink
    /firmware/App/Drivers/SafetyShutdown.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeDrain.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeHeatDisinfect.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeHeatDisinfect.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeInitPOST.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeRecirculate.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeStandby.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeStandby.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/OperationModes.c Changed
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmt.h Changed 9
    Open in IDE #permalink
    /firmware/App/Services/CommBuffers.c Changed
    Open in IDE #permalink
    /firmware/App/Services/FPGA.c Changed
    Open in IDE #permalink
    /firmware/App/Services/FPGA.h Changed
    Open in IDE #permalink
    /firmware/App/Services/MessagePayloads.h Added
    Open in IDE #permalink
    /firmware/App/Services/PIControllers.c Changed 3
    Open in IDE #permalink
    /firmware/App/Services/PIControllers.h Changed
    Open in IDE #permalink
    /firmware/App/Services/SystemComm.c Changed 3
    Open in IDE #permalink
    /firmware/App/Services/SystemComm.h Changed 3
    Open in IDE #permalink
    /firmware/.../Services/SystemCommMessages.c Changed 3
    Open in IDE #permalink
    /firmware/.../Services/SystemCommMessages.h Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskGeneral.c Changed 5
    Open in IDE #permalink
    /firmware/App/DGCommon.h Changed
    Open in IDE #permalink
    /firmware/include/het.h Changed 6
    Open in IDE #permalink
    /firmware/source/het.c Added
    Open in IDE #permalink
    /firmware/source/notification.c Changed
    Open in IDE #permalink
    /firmware/source/pinmux.c Changed
    Open in IDE #permalink
    /firmware/source/sys_main.c Changed
    Open in IDE #permalink
    /firmware/DG.dil Changed
    Open in IDE #permalink
    /firmware/DG.hcg Changed
    Open in IDE #permalink
    /Common.h Changed
    Open in IDE #permalink
    /PersistentAlarm.h Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time