This is a list of all comments for DG-DEN-3504-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/ModeDrain.c Revision Comment by Sean Nash on 07 October 2020, 10:29 https://devapps.diality.us/cru/DG-DEN-3504-1#c5324 0.1 what? I assume grams. Add units to #define or at least comments to clarify. 0.1 g is a very tight tolerance. Reply by qnguyen on 07 October 2020, 11:19 > Removed. Used lowest weight to detect unchanged weight. Reply by Sean Nash on 02 November 2020, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 October 2020, 10:19 https://devapps.diality.us/cru/DG-DEN-3504-1#c5790 we are (instead of we're) Reply by qnguyen on 30 October 2020, 14:55 > Changed we've to we have. Reply by pmontazemi on 02 November 2020, 10:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 07 October 2020, 10:40 https://devapps.diality.us/cru/DG-DEN-3504-1#c5328 We will want to auto-cal A2/B2 redundant load cells as well. One or neither or both load cells may require auto-cal if they stop falling before reaching target weight. Reply by qnguyen on 07 October 2020, 14:29 > Done inside reservoir module. Reply by Sean Nash on 02 November 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 07 October 2020, 10:43 https://devapps.diality.us/cru/DG-DEN-3504-1#c5329 Weight should be dropping. Probably shouldn't use fabs here. Reply by qnguyen on 07 October 2020, 11:19 > Done inside reservoir module. Reply by Sean Nash on 02 November 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 07 October 2020, 10:43 https://devapps.diality.us/cru/DG-DEN-3504-1#c5330 Consider moving this assignment to an else for the above condition. Reply by qnguyen on 07 October 2020, 14:30 > Removed and used lowest weight instead. Reply by Sean Nash on 02 November 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 07 October 2020, 10:44 https://devapps.diality.us/cru/DG-DEN-3504-1#c5331 Target weight can be anything - comes from the HD. For calibration, I think we should be using a #define for what we think the fluid weight would be when reservoir drained to end of drain straw. Reply by qnguyen on 07 October 2020, 14:30 > The calibration offset will be what left over after a full > drain. Reply by Sean Nash on 02 November 2020, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 07 October 2020, 10:53 https://devapps.diality.us/cru/DG-DEN-3504-1#c5333 Another condition to add here: If we auto-cal one or both load cells, we should consider the drain activity completed (we cannot drain any further) and exit drain mode. Reply by qnguyen on 07 October 2020, 14:31 > Done. Reply by Sean Nash on 02 November 2020, 10:36 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Drivers/Comm.c Revision Comment by pmontazemi on 30 October 2020, 10:18 https://devapps.diality.us/cru/DG-DEN-3504-1#c5787 Why removed? Reply by qnguyen on 30 October 2020, 10:59 > The function has been moved upward in order defined in the > header Comm.h. Reply by pmontazemi on 02 November 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 October 2020, 10:18 https://devapps.diality.us/cru/DG-DEN-3504-1#c5788 Why removed? Reply by qnguyen on 30 October 2020, 11:05 > The function has been moved upward in order defined in the > header Comm.h. Reply by pmontazemi on 02 November 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 October 2020, 10:18 https://devapps.diality.us/cru/DG-DEN-3504-1#c5789 Why removed? Reply by qnguyen on 30 October 2020, 10:58 > The function has been moved upward in order defined in the > header Comm.h. Reply by pmontazemi on 02 November 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/ConductivitySensors.c Revision Comment by pmontazemi on 30 October 2020, 10:08 https://devapps.diality.us/cru/DG-DEN-3504-1#c5785 1. SIEMENS_TO_MICROSIEMENS_CONVERSION (Ss are missing) 2. Siemens (not Siemen) to microSiemens Reply by qnguyen on 30 October 2020, 14:46 > Done. Reply by pmontazemi on 02 November 2020, 10:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 October 2020, 10:10 https://devapps.diality.us/cru/DG-DEN-3504-1#c5786 Allowed or allow? If allowed, please correct for all lines. Reply by Sean Nash on 30 October 2020, 11:15 > I think it should say "required" after adding acid. Reply by qnguyen on 30 October 2020, 14:52 > I think minimum and maximum already indicates the smallest > and highest value. Removed allow. Reply by pmontazemi on 02 November 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 02 November 2020, 09:16 https://devapps.diality.us/cru/DG-DEN-3504-1#c5833 You have defined the data struct in the .h but why are you not using it? Reply by qnguyen on 02 November 2020, 10:30 > Done. Reply by Dara Navaei on 02 November 2020, 10:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:17 https://devapps.diality.us/cru/DG-DEN-3504-1#c6003 Add blank line between local function declarations and code. Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:18 https://devapps.diality.us/cru/DG-DEN-3504-1#c6004 Remove extra blank line. Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:18 https://devapps.diality.us/cru/DG-DEN-3504-1#c6005 Add space before end ). Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:19 https://devapps.diality.us/cru/DG-DEN-3504-1#c6006 Add space between local function declarations and code. Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 02 November 2020, 09:14 https://devapps.diality.us/cru/DG-DEN-3504-1#c5832 Don't we need a #define for these values? Reply by qnguyen on 02 November 2020, 10:29 > Done. Reply by Dara Navaei on 02 November 2020, 10:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:21 https://devapps.diality.us/cru/DG-DEN-3504-1#c6007 Consider moving this function to common Utilities module. Could be shared by other modules. Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:22 https://devapps.diality.us/cru/DG-DEN-3504-1#c6008 Add blank line between local function declarations and code. Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:23 https://devapps.diality.us/cru/DG-DEN-3504-1#c6009 Move code below declarations. Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:23 https://devapps.diality.us/cru/DG-DEN-3504-1#c6010 Remove blank line. Reply by qnguyen on 10 November 2020, 12:10 > Done. Reply by Sean Nash on 12 November 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:23 https://devapps.diality.us/cru/DG-DEN-3504-1#c6011 Add blank line between local declarations and code. Reply by qnguyen on 10 November 2020, 12:11 > Done. Reply by Sean Nash on 12 November 2020, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 02 November 2020, 09:13 https://devapps.diality.us/cru/DG-DEN-3504-1#c5831 Need a space here. Reply by qnguyen on 02 November 2020, 10:29 > Done. Reply by Dara Navaei on 02 November 2020, 10:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:24 https://devapps.diality.us/cru/DG-DEN-3504-1#c6012 Update @params to match function parameters. Reply by qnguyen on 10 November 2020, 12:11 > Done. Reply by Sean Nash on 12 November 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeFill.c Revision Comment by Sean Nash on 13 November 2020, 09:37 https://devapps.diality.us/cru/DG-DEN-3504-1#c6185 I don't see this function actually exiting the mode. Is it caller's responsibility to return to re-circ mode after calling this function? Reply by qnguyen on 13 November 2020, 10:46 > It was acting as a function to turn off concentrate pump if > HD commands DG exits fill mode, but has been removed due to > reservoir module will handle this. Reply by Sean Nash on 17 November 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/OperationModes.c Revision Comment by Sean Nash on 13 November 2020, 09:40 https://devapps.diality.us/cru/DG-DEN-3504-1#c6186 We should think about this. I'm ok with adding an explicit transition out handler (similar to the existing transition to handler), but if we do this we should build this into all modes (DG and HD). To date, I've not required any clean-up on way out of a mode - mode can be reset on next entry. That seems to have been working so far. Valve positions and motor states should be set as appropriate on entry to next mode, so we shouldn't have to worry about these kind of things on way out of a mode. Reply by qnguyen on 13 November 2020, 10:48 > This was responsible for turn off concentrate pumps when HD > commands DG to exit out of fill mode, but reservoir module > has handled this. Reply by Sean Nash on 17 November 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/Reservoirs.c Revision Comment by Sean Nash on 10 November 2020, 10:38 https://devapps.diality.us/cru/DG-DEN-3504-1#c6014 Change associate to associated. Reply by qnguyen on 10 November 2020, 12:11 > Done. Reply by Sean Nash on 12 November 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:40 https://devapps.diality.us/cru/DG-DEN-3504-1#c6015 Consider initializing these to something higher than anything possibly real so that it will never look lower than a real measurement. Reply by qnguyen on 10 November 2020, 12:11 > Done. Reply by Sean Nash on 12 November 2020, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:43 https://devapps.diality.us/cru/DG-DEN-3504-1#c6016 I would think you would need this to be an array (one element for each reservoir) so that you can clear request for each when tare is completed. Reply by qnguyen on 10 November 2020, 12:12 > The tare load cell request is flagged at the start of a drain > command. That means we only drain and tare one reservoir at a > time. Reply by Sean Nash on 12 November 2020, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:47 https://devapps.diality.us/cru/DG-DEN-3504-1#c6017 I think we should only use primary load cell (not redundant) for these types of determinations. Redundant load cell is just for safety. Reply by qnguyen on 10 November 2020, 12:11 > Done. Reply by Sean Nash on 12 November 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:48 https://devapps.diality.us/cru/DG-DEN-3504-1#c6018 Again, just look at primary load cell for functional determinations. Redundant is just for safety. However, we do want to tare both when it's time. Reply by qnguyen on 10 November 2020, 12:11 > Done. Reply by Sean Nash on 12 November 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/Reservoirs.h Revision Comment by Sean Nash on 10 November 2020, 10:34 https://devapps.diality.us/cru/DG-DEN-3504-1#c6013 Add "Been" to function names (e.g. hasTargetFillVolumeBeenReached()). Reply by qnguyen on 10 November 2020, 12:15 > Done. Reply by Sean Nash on 12 November 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/ConcentratePumps.c Revision Comment by Sean Nash on 10 November 2020, 08:58 https://devapps.diality.us/cru/DG-DEN-3504-1#c5974 Fix spelling error (increment). Is this a maximum increment? If so, change name and add to comment. Reply by qnguyen on 10 November 2020, 11:36 > Done. This is not a maximum increment. Reply by Sean Nash on 12 November 2020, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 16 November 2020, 08:20 https://devapps.diality.us/cru/DG-DEN-3504-1#c6225 There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to control the pumps independently in this mode. Reply by qnguyen on 17 November 2020, 10:36 > Pumps are now controlled individually. Reverse direction for > motor has been added. Reply by Sean Nash on 17 November 2020, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:13 https://devapps.diality.us/cru/DG-DEN-3504-1#c5976 Add decimal point to literals that will be used in floating point equations. Reply by qnguyen on 10 November 2020, 11:36 > Done. Reply by Sean Nash on 12 November 2020, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:21 https://devapps.diality.us/cru/DG-DEN-3504-1#c5977 Number of micro-steps per what? Reply by qnguyen on 10 November 2020, 11:36 > Renamed to indicate micro-steps per step. Reply by Sean Nash on 12 November 2020, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:24 https://devapps.diality.us/cru/DG-DEN-3504-1#c5979 Add decimal point to 2. Add more to comment to explain the 2 x 0.25 part of this definition. Reply by qnguyen on 10 November 2020, 11:37 > Changed (2 x 0.25) to 0.5 and indicated 0.5 us is the step > period resolution. Reply by Sean Nash on 12 November 2020, 10:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 02 November 2020, 08:48 https://devapps.diality.us/cru/DG-DEN-3504-1#c5828 Need a space here. Reply by qnguyen on 02 November 2020, 10:34 > Done. Reply by Dara Navaei on 02 November 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:26 https://devapps.diality.us/cru/DG-DEN-3504-1#c5981 Add units to step speed in comment. Steps per step period? Step period is 0.5 uSec? Reply by qnguyen on 12 November 2020, 10:50 > Changed variable name and added units in comment. Reply by Sean Nash on 12 November 2020, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:33 https://devapps.diality.us/cru/DG-DEN-3504-1#c5982 Should you initialize pumpTargetSpeed[] elements here? Reply by qnguyen on 10 November 2020, 09:55 > It is initialized inside function stopConcentratePump(). Reply by Sean Nash on 12 November 2020, 10:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 02 November 2020, 08:50 https://devapps.diality.us/cru/DG-DEN-3504-1#c5830 I don't know if it is mandatory, but we adopted a new way to transfer publish data to broadcast function using a public struct in the .h file and passing a pointer from it. I think we should do it that way everywhere. Reply by qnguyen on 02 November 2020, 10:30 > Done. Reply by Dara Navaei on 02 November 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:37 https://devapps.diality.us/cru/DG-DEN-3504-1#c5983 Measured speed is not kept - only broadcast. Are there any checks to be added to this monitor function? Should measured speed be checked vs. commanded speed? Consider keeping measured speed in an override array if you are going to check it. Reply by qnguyen on 12 November 2020, 10:49 > Measured speed is kept in an override array. > Added checking for measured speed vs. commanded speed. Reply by Sean Nash on 12 November 2020, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 02 November 2020, 08:49 https://devapps.diality.us/cru/DG-DEN-3504-1#c5829 Need a space after each break. Reply by qnguyen on 02 November 2020, 10:30 > Done. Reply by Dara Navaei on 02 November 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:39 https://devapps.diality.us/cru/DG-DEN-3504-1#c5984 I notice the 2 concentrate pumps are always turned off/on together - no way to command 1 pump and not the other. Assume this is by design and that there are no use cases for individual pump control? Rename function to ...PumpsOn(). Reply by qnguyen on 10 November 2020, 10:02 > For dialysate mixing, I do not see a use case where one pump > is on and the other pump is off. Reply by Sean Nash on 12 November 2020, 10:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:44 https://devapps.diality.us/cru/DG-DEN-3504-1#c5988 Rename function to ...PumpsOff(). Reply by qnguyen on 10 November 2020, 12:05 > Done. Reply by Sean Nash on 12 November 2020, 10:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:45 https://devapps.diality.us/cru/DG-DEN-3504-1#c5991 Recommend splitting this condition into separate pump ID validation and target speed range check conditions. Then you won't have to determine reason for alarm in else below. Reply by qnguyen on 10 November 2020, 12:05 > Done. Reply by Sean Nash on 12 November 2020, 10:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:50 https://devapps.diality.us/cru/DG-DEN-3504-1#c5994 If pumpTargetSpeed is an override, then why would we destroy the override when f/w wants to stop the pumps? Shouldn't this function only zero the .data field and let the override remain? I would consider removing the override aspect of pumpTargetSpeed[]. Let Dialin set the target speed by having "test" function call setConcentratePumpTargetSpeed() with given rate for given pump. Then leave this function to stop pumps as currently structured. Reply by qnguyen on 10 November 2020, 12:06 > Done. Reply by Sean Nash on 12 November 2020, 10:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:02 https://devapps.diality.us/cru/DG-DEN-3504-1#c5975 speedIncrease is a float so literals should have decimal point. Change -1 to -1.0. Reply by qnguyen on 10 November 2020, 12:06 > Done. Reply by Sean Nash on 12 November 2020, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:58 https://devapps.diality.us/cru/DG-DEN-3504-1#c5997 Put local declaration at top of function. Reply by qnguyen on 10 November 2020, 12:06 > Putting local declaration at top of function will remove the > const. Should we allow this type of declaration where > variable is closest to the location it is being used? Reply by Sean Nash on 12 November 2020, 10:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 09:59 https://devapps.diality.us/cru/DG-DEN-3504-1#c5998 Should this conversion from float to U16 be rounded instead of floored for better accuracy? Reply by qnguyen on 10 November 2020, 12:07 > Rounded the conversion. Reply by Sean Nash on 12 November 2020, 10:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 02 November 2020, 08:47 https://devapps.diality.us/cru/DG-DEN-3504-1#c5827 Missing function header. Reply by qnguyen on 02 November 2020, 10:30 > Done. Reply by Dara Navaei on 02 November 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:00 https://devapps.diality.us/cru/DG-DEN-3504-1#c5999 Missing @param in function header. Reply by qnguyen on 10 November 2020, 12:15 > Function has been removed. Reply by Sean Nash on 12 November 2020, 10:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2020, 10:00 https://devapps.diality.us/cru/DG-DEN-3504-1#c6000 Software faults should have data to distinguish which s/w fault is being triggered (helps when looking at event logs). This may be a moot point if you change pumpTargetSpeed to non-override which would make this function obsolete. Reply by qnguyen on 10 November 2020, 12:09 > Removed the function. Reply by Sean Nash on 12 November 2020, 10:42 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.h Revision Comment by pmontazemi on 17 November 2020, 10:33 https://devapps.diality.us/cru/DG-DEN-3504-1#c6241 Not a big fan of numbering variables like Speed1, Speed2, etc. Reply by qnguyen on 17 November 2020, 10:39 > Good catch, it is actually an unintended L. Removed. Reply by pmontazemi on 23 November 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/ConductivitySensors.h Revision Comment by Sean Nash on 10 November 2020, 10:07 https://devapps.diality.us/cru/DG-DEN-3504-1#c6002 For modules that are controlling or monitoring h/w, add details of the h/w in the module brief (mfg, p/n, any summary details from data sheet, ...). Reply by qnguyen on 10 November 2020, 12:09 > Done. Reply by Sean Nash on 12 November 2020, 10:41 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/DGCommon.h Revision Comment by pmontazemi on 30 October 2020, 10:44 https://devapps.diality.us/cru/DG-DEN-3504-1#c5794 TODO is missing if it is intended to keep these comments, otherwise delete. Reply by qnguyen on 30 October 2020, 11:08 > [~snash] These flags might still be needed. What do you > think? Reply by Sean Nash on 30 October 2020, 11:11 > I think Behrouz still uses that one. We need to be able to > comment and uncomment as needed to achieve the desired > build. Do not remove. For Bamboo and Vectorcast, none of > these are seen so it has no impact on release builds or > unit testing. Reply by pmontazemi on 02 November 2020, 10:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/MessagePayloads.h Revision Comment by pmontazemi on 30 October 2020, 10:40 https://devapps.diality.us/cru/DG-DEN-3504-1#c5793 Why removed? Reply by qnguyen on 30 October 2020, 11:07 > Moved this data structure to the corresponding module, which > is conductivity sensors in this case. Reply by pmontazemi on 02 November 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. --- ID: DG-DEN-3504-1 https://devapps.diality.us/cru/DG-DEN-3504-1 Title: DG-DEN-3504_DG Dialysate Composition (1 of 2) Statement of Objectives: State: Closed Summary: Author: qnguyen Reviewers: (1 active, 2 completed*) Dara Navaei (*) pmontazemi (*) Sean Nash