DG-DEN-5855-1 DG-DEN-5855_DG Drain Pump (2 of 2)

closed on 11 Dec 20

Author

Reviewers

DG-DEN-5855_DG Drain Pump (2 of 2)

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 29

common 0
- File AlarmDefs.h 0 Remove
- File DGDefs.h 0 Remove
- File MsgDefs.h 0 Remove
dgfirmware 0
- Folder firmware 0
  - Folder App 0
    - Folder Controllers 0
      - File ConcentratePumps.c 0 Remove
      - File ConductivitySensors.c 0 Remove
      - File DrainPump.c 22 Remove
      - File DrainPump.h 0 Remove
      - File Pressures.c 0 Remove
      - File ROPump.c 27 Remove
      - File ROPump.h 0 Remove
      - File TemperatureSensors.c 0 Remove
      - File UVReactors.c 0 Remove
      - File UVReactors.h 0 Remove
    - Folder Modes 0
      - File ModeDrain.c 0 Remove
      - File ModeFill.c 0 Remove
      - File ModeInitPOST.c 0 Remove
      - File ModeRecirculate.c 0 Remove
    - Folder Services 0
      - File AlarmMgmt.h 0 Remove
      - File MessagePayloads.h 0 Remove
      - File PIControllers.c 0 Remove
      - File PIControllers.h 3 Remove
      - File SystemComm.c 3 Remove
      - File SystemCommMessages.c 33 Remove
      - File SystemCommMessages.h 3 Remove
    - Folder Tasks 0
      - File TaskGeneral.c 0 Remove
  - Folder source 0
    - File sys_main.c 0 Remove
fwcommon 0
- File Common.h 0 Remove
- File PersistentAlarm.c 0 Remove
- File PersistentAlarm.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author	1h 33m	30	Done
qnguyen (deleted user)	Reviewer - Complete	1h 12m	40	RESOLVED in CODE WALKTHROUGH.
Sean Nash	Reviewer - Complete	56m	19	RESOLVED in CODE WALKTHROUGH.
pmontazemi (deleted user)	Reviewer - Complete	47m	2	RESOLVED in CODE WALKTHROUGH.
Total		4h 30m	91

Linked issues
- DEN-5855

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DG-DEN-5855-1

DG-DEN-5855_DG Drain Pump (2 of 2)

DG-DEN-5855-1 91

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DG-DEN-5855_DG Drain Pump (2 of 2)

DG-DEN-5855-1 91

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time