This is a list of all comments for DG-DEN-6081-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Sean Nash on 29 December 2020, 09:28 
https://devapps.diality.us/cru/DG-DEN-6081-1#c6872

  Add parenthesis around first condition in if as well.

  Reply by Dara Navaei on 29 December 2020, 20:19
  > Done

    Reply by Sean Nash on 30 December 2020, 14:06
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 29 December 2020, 09:29 
https://devapps.diality.us/cru/DG-DEN-6081-1#c6873

  Always trigger a fault when pulling the safety line.

  Reply by Dara Navaei on 29 December 2020, 20:32
  > I added a persistent alarm.

    Reply by Sean Nash on 30 December 2020, 14:04
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by qnguyen on 28 December 2020, 20:20 
https://devapps.diality.us/cru/DG-DEN-6081-1#c6861

  Suggest replace target RO pump pressure function call with
  local variable targetFlowRate and separating condition using
  parentheses

  Reply by Dara Navaei on 29 December 2020, 20:35
  > Done

    Reply by qnguyen on 30 December 2020, 14:11
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-6081-1 https://devapps.diality.us/cru/DG-DEN-6081-1

Title: DG-DEN-6081_Revisit DG RO Pump Ramp Up Timeout Alarm
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     pmontazemi   (*)