This is a list of all comments for DG-DEN-6890-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/FluidLeak.c
Revision Comment by Sean Nash on 09 March 2021, 16:54 
https://devapps.diality.us/cru/DG-DEN-6890-1#c8282

  Probably don't need OperationModes.h either.

  Reply by pmontazemi on 10 March 2021, 14:02
  > Removed.

    Reply by Sean Nash on 11 March 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 09 March 2021, 16:57 
https://devapps.diality.us/cru/DG-DEN-6890-1#c8285

  Did you add a call to this function in TaskPriority.c?

  Reply by pmontazemi on 10 March 2021, 14:02
  > Added.

    Reply by Sean Nash on 11 March 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 09 March 2021, 16:58 
https://devapps.diality.us/cru/DG-DEN-6890-1#c8286

  If no params, just remove this line from header.

  Reply by Dara Navaei on 19 October 2023, 08:11
  > RESOLVED in CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Controllers/FluidLeak.h
Revision Comment by Dara Navaei on 10 March 2021, 23:45 
https://devapps.diality.us/cru/DG-DEN-6890-1#c8296

  We started adding the sensors's part number and model. Could
  you please add it here?

  Reply by pmontazemi on 11 March 2021, 12:33
  > Addressed for both DG and HD.

    Reply by Dara Navaei on 12 March 2021, 10:31
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/FPGA.c
Revision Comment by Dara Navaei on 10 March 2021, 23:47 
https://devapps.diality.us/cru/DG-DEN-6890-1#c8297

  Why is this called fpgaGPIO? Why not leakDetector or something
  that is more representative of your driver?

  Reply by pmontazemi on 11 March 2021, 10:30
  > Because the fluid leak detector is packaged as part of a
  > 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This
  > is to save space. I use a bitmask to extract that one bit I
  > need which is representative of the fluid leak detector state
  > (dry/1 vs. wet/0).

    Reply by Dara Navaei on 11 March 2021, 10:40
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-6890-1 https://devapps.diality.us/cru/DG-DEN-6890-1

Title: DG-DEN-6890_Fluid Leak Detector Driver
Statement of Objectives:


State: Closed

Summary: 

Author: pmontazemi
Moderator: pmontazemi
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     Dara Navaei   (*)