DG-DEN-7091-1 DG-DEN-7091_Pre Treatment Mode

closed on 06 Apr 21

Author

Reviewers

DG-DEN-7091_Pre Treatment Mode

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 40

common 0
- File AlarmDefs.h 0 Remove
- File DGDefs.h 0 Remove
- File HDDefs.h 0 Remove
- File MsgDefs.h 0 Remove
dgfirmware 0
- Folder firmware 0
  - Folder App 0
    - Folder Controllers 0
      - File ConcentratePumps.c 0 Remove
      - File ConcentratePumps.h 0 Remove
      - File ConductivitySensors.c 0 Remove
      - File ConductivitySensors.h 0 Remove
      - File DrainPump.c 0 Remove
      - File LoadCell.c 0 Remove
      - File LoadCell.h 0 Remove
      - File Pressures.c 0 Remove
      - File TemperatureSensors.c 0 Remove
    - Folder Modes 0
      - File ModeDrain.c 0 Remove
      - File ModeFill.c 13 Remove
      - File ModeFill.h 0 Remove
      - File ModeRecirculate.c 0 Remove
      - File ModeStandby.c 0 Remove
      - File ModeStandby.h 0 Remove
      - File OperationModes.c 3 Remove
    - Folder Services 0
      - File AlarmMgmt.c 0 Remove
      - File AlarmMgmt.h 0 Remove
      - File CommBuffers.h 0 Remove
      - File FPGA.c 0 Remove
      - File Reservoirs.c 6 Remove
      - File Reservoirs.h 0 Remove
      - File SystemComm.c 6 Remove
      - File SystemCommMessages.c 0 Remove
      - File SystemCommMessages.h 0 Remove
    - Folder Tasks 0
      - File TaskGeneral.c 0 Remove
    - File DGCommon.h 3 Remove
  - Folder source 0
    - File can.c 0 Remove
  - File DG.dil 0 Remove
fwcommon 0
- File Accel.c 0 Remove
- File Accel.h 0 Remove
- File NVDataMgmt.c 0 Remove
- File PersistentAlarm.c 0 Remove
- File PersistentAlarm.h 0 Remove
- File TestSupport.h 0 Remove
- File Utilities.c 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
qnguyen (deleted user)	Author	1h 32m	10	Checked with Nick. The DG does not expose motors to the u...
Sean Nash	Reviewer - Complete	1h 27m	19	RESOLVED in CODE WALKTHROUGH.
Dara Navaei	Reviewer - 1% reviewed	0m
pmontazemi (deleted user)	Reviewer - Complete	1h 9m	2	RESOLVED in CODE WALKTHROUGH.
Total		4h 10m	31

Linked issues
- DEN-7091

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DG-DEN-7091-1

DG-DEN-7091_Pre Treatment Mode

DG-DEN-7091-1 31

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DG-DEN-7091_Pre Treatment Mode

DG-DEN-7091-1 31

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time