This is a list of all comments for DG-DEN-7091-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by Sean Nash on 13 March 2021, 19:31 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8341

  I think there are now 7 incoming CAN msg buffers (8 if counting
  the 1 serial port buffer).

  Reply by qnguyen on 13 March 2021, 21:25
  > Fixed.

    Reply by Sean Nash on 19 March 2021, 10:46
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pmontazemi on 28 February 2021, 22:11 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8250

  Why removed?

  Reply by qnguyen on 01 March 2021, 08:48
  > Due to changes from non-volatile data management, this
  > message is no longer available.
  > Need to remove to fix build.

    Reply by pmontazemi on 01 March 2021, 10:39
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/Reservoirs.c
Revision Comment by Sean Nash on 01 March 2021, 09:53 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8256

  I think setActiveReservoirCMD() sets activeReservoir.data for
  you.  Redundant.

  Reply by qnguyen on 01 March 2021, 10:25
  > Removed.

    Reply by Sean Nash on 01 March 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 19 March 2021, 09:28 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8384

  This init is called from main at startup.  This seems to work,
  but I'd prefer to select initial active reservoir and set
  reservoir valves accordingly after POST - maybe in transition
  to standby mode.  This way, if POST does something to the
  valves to test, we will set them afterward.  Also gives valve
  driver and FPGA interface a chance to get started before we
  start giving actuator commands.

  Reply by qnguyen on 19 March 2021, 10:17
  > Moved valves config to standby mode transition.

    Reply by Sean Nash on 19 March 2021, 10:43
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/DGCommon.h
Revision Comment by Sean Nash on 19 March 2021, 09:33 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8385

  Let's update to v0.5.0.

  Reply by qnguyen on 19 March 2021, 10:17
  > Updated.

    Reply by Sean Nash on 19 March 2021, 10:43
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by Sean Nash on 13 March 2021, 19:56 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8344

  conver should be convert.  Flow is in L/min.

  Reply by qnguyen on 13 March 2021, 21:25
  > Fixed.

    Reply by Sean Nash on 19 March 2021, 10:44
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 March 2021, 10:48 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8450

  Should we have a timeout on this?

  Reply by qnguyen on 22 March 2021, 11:40
  > Added timeout.

    Reply by Sean Nash on 23 March 2021, 11:18
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 March 2021, 10:51 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8452

  Do we need to know if concentrates door is closed before
  turning on pumps?

  Reply by qnguyen on 22 March 2021, 11:54
  > Checked with Nick. The DG does not expose motors to the user.
  > The straw door switch should be open in Fill Mode to allow
  > access to straw connection.
  > The straw door switch should be closed in modes such as (heat
  > disinfection, chem disinfection) to prevent user from
  > exposure to hot water or chemical.
  > 
  > Added TODO.

    Reply by Sean Nash on 23 March 2021, 11:17
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 13 March 2021, 19:44 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8342

  Don't we need to check other things here as well?  Inlet temp
  and conductivity, reject ratio, and dialysate temperature.

  Reply by qnguyen on 13 March 2021, 20:32
  > The return of this function includes a call to
  > isWaterQualityGood(), which checks for inlet temp and
  > conductivity, reject ratio, and temperature.
  > For the dialysate temperature, it will be done once I work on
  > dialysate generation again and remove TODO.

    Reply by Sean Nash on 13 March 2021, 20:43
    > Ok, yes, I see that now.  But I still don't see any check
    > for dialysate temperature (after heating).

      Reply by Sean Nash on 19 March 2021, 10:45
      > Quang to address temperature in future branch.  RESOLVED
      > in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Sean Nash on 22 March 2021, 10:54 
https://devapps.diality.us/cru/DG-DEN-7091-1#c8454

  Should we send DG modes more often?  UI and HD stacks are
  keying off of these a lot and I worry 1 Hz will not be very
  responsive.  I also worry there may be some modes/states that
  do not last 1 second and HD may miss it.
  If we speed this up, we should also speed up the HD modes
  broadcast as well.

  Reply by qnguyen on 22 March 2021, 11:41
  > Changed rate to 4 Hz.

    Reply by Sean Nash on 23 March 2021, 11:17
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-7091-1 https://devapps.diality.us/cru/DG-DEN-7091-1

Title: DG-DEN-7091_Pre Treatment Mode
Statement of Objectives:


State: Closed

Summary: 

Author: qnguyen
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)
     Dara Navaei