This is a list of all comments for DG-DEN-7605-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Voltages.c
Revision Comment by Dara Navaei on 15 May 2021, 09:51 
https://devapps.diality.us/cru/DG-DEN-7605-1#c9867

  I thought we decided to pass the broadcast data as a reference.
  Did we change that?

  Reply by Sean Nash on 20 May 2021, 08:57
  > I have no preference on that.  Data is temporary either way.
  > By reference is a little easier on the stack.

    Reply by Dara Navaei on 21 May 2021, 10:42
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeDrain.c
Revision Comment by qnguyen on 26 May 2021, 08:58 
https://devapps.diality.us/cru/DG-DEN-7605-1#c10120

  Should this be in interval count?

  Reply by Sean Nash on 26 May 2021, 09:06
  > Yes.  Fixed.

    Reply by qnguyen on 27 May 2021, 10:32
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/Reservoirs.c
Revision Comment by qnguyen on 26 May 2021, 09:02 
https://devapps.diality.us/cru/DG-DEN-7605-1#c10121

  Consider re-word to something more general. This function might
  be used by ModeHeatDisinfect to tare on an active reservoir.

  Reply by Sean Nash on 26 May 2021, 09:35
  > Fixed.

    Reply by qnguyen on 27 May 2021, 10:32
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by pmontazemi on 19 May 2021, 15:28 
https://devapps.diality.us/cru/DG-DEN-7605-1#c9963

  Align comment.

  Reply by Sean Nash on 21 May 2021, 10:20
  > Fixed.

    Reply by pmontazemi on 27 May 2021, 10:32
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pmontazemi on 19 May 2021, 15:29 
https://devapps.diality.us/cru/DG-DEN-7605-1#c9964

  If we align, we align everything, otherwise, no extra spaces
  between variables and the "=" sign.

  Reply by Sean Nash on 21 May 2021, 10:20
  > Fixed.

    Reply by pmontazemi on 27 May 2021, 10:31
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-7605-1 https://devapps.diality.us/cru/DG-DEN-7605-1

Title: DG-DEN-7605_HD DG Self Tests
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Dara Navaei   (*)
     pmontazemi   (*)