This is a list of all comments for DG-DENBUG-307-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.c
Revision Comment by Sean Nash on 01 April 2025, 08:59 
https://devapps.diality.us/cru/DG-DENBUG-307-1#c21859

  Measured speed (whether real or override) should always be
  positive.  And if that's true, we shouldn't need this
  exception.

  Reply by Dara Navaei on 02 April 2025, 10:28
  > Done

    Reply by Sean Nash on 02 April 2025, 11:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 01 April 2025, 09:01 
https://devapps.diality.us/cru/DG-DENBUG-307-1#c21860

  Aren't speeds (commanded and measured) always positive?  Do we
  need the fabs?

  Reply by Dara Navaei on 02 April 2025, 10:26
  > I used fabs so all are positive when monitoring is started.

    Reply by Sean Nash on 02 April 2025, 11:13
    > Not needed, but benign.  RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 01 April 2025, 09:03 
https://devapps.diality.us/cru/DG-DENBUG-307-1#c21861

  This check doesn't make sense to me.  Measured speed will only
  be negative if set direction is reverse.  So how could
  directions ever not match?

  Reply by Dara Navaei on 02 April 2025, 10:27
  > Done

    Reply by Sean Nash on 02 April 2025, 11:13
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1

Title: DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Vinayakam Mani
     amanesh
     Daniel Ho