This is a list of all comments for DG-DIAL-273-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 04 August 2023, 10:11 
https://devapps.diality.us/cru/DG-DIAL-273-1#c18442

  This is non-standard override record and approach.  Is there
  any reason why you didn't just create a separate override
  command and message to override raw flow?

  Reply by Michael Garthwaite on 07 August 2023, 08:48
  > We're starting seeing a trend where V&V want to override
  > pre-calibrated values ( like the LC structure above ). I
  > followed the LC override style since it has similar behavior.
  > I have no issue splitting

    Reply by Sean Nash on 08 August 2023, 11:28
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/FlowSensors.c
Revision Comment by wbracken on 03 August 2023, 12:33 
https://devapps.diality.us/cru/DG-DIAL-273-1#c18411

  Update @param with raw

  Reply by Michael Garthwaite on 08 August 2023, 13:17
  > Fixed. Thanks!

    Reply by wbracken on 08 August 2023, 13:26
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Sean Nash on 08 August 2023, 10:58 
https://devapps.diality.us/cru/DG-DIAL-273-1#c18489

  Remove blank line.

  Reply by Michael Garthwaite on 08 August 2023, 12:00
  > Fixed. Thanks!

    Reply by Sean Nash on 08 August 2023, 12:33
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DIAL-273-1 https://devapps.diality.us/cru/DG-DIAL-273-1

Title: DG-DIAL-273_Need Override For Dg.Flow Sensors.Measured Raw Dialysate Flow Lpm
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe