This is a list of all comments for DIALIN-2.

Review Summary: No summary

General Comment by Behrouz NematiPour on 08 September 2020, 11:51 
https://devapps.diality.us/cru/DIALIN-2#c4459

  Why this code review starts with "UI_" it's all Dialin.
  Shouldn't it be started with Dialin?

  Reply by plucia on 09 September 2020, 10:44
  > I have updated it so it says Dialin now.

    Reply by Behrouz NematiPour on 30 September 2020, 12:10
    > RESOLVED


----------------------------------------
File: requirements.txt
Revision Comment by Behrouz NematiPour on 08 September 2020, 11:57 
https://devapps.diality.us/cru/DIALIN-2#c4460

  I have some questions regarding these libraries.
  1 - What tool/code is checking for these requirements?
  2 - What if the requirement is not met? (not a correct version
  or lib not exists)
  3 - If the lib does not exist is it going to be installed or
  thrown an error?
  4 - Don't we need to validate all these libraries?
  5 - What is our process of adding more libraries to the list?
  On the other way is it fine to have all these libs? are all of
  them being used?

  Reply by plucia on 09 September 2020, 10:46
  > 1 - pip uses requirements.txt to install dependencies. See
  > tools/setup_environment.sh for more detail.
  > 2 - What you're asking about is the offline install
  > capability. I have created a ticket in Jira
  > [http://dvm-linux02:8080/browse/DIAL-34] to track this new
  > feature request.
  > 3 - The offline install capability addresses this situation,
  > in the (very) unlikely event that pypi hosting can't be
  > relied upon.
  > 4 - No. My understanding is that we do not need to validate
  > these libraries because Dialin is NPSW.
  > 5 - It's fine to have all of these libraries. For example,
  > some of them are dependencies of python-can. Periodically
  > this requirements.txt will be cleaned if a library is no
  > longer being used. For this change-set, I added flake8 so we
  > can run static code analysis. Flake8 is installed along with
  > its dependencies.

    Reply by Behrouz NematiPour on 30 September 2020, 12:11
    > Good,
    > So please consider cleaning up used libraries periodically.
    > 
    > RESOLVED.


---

ID: DIALIN-2 https://devapps.diality.us/cru/DIALIN-2

Title: Dialin DEN-4589_Sprint_26
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Moderator: plucia
Reviewers: (0 active, 2 completed*)
     Sean Nash   (*)
     Behrouz NematiPour   (*)