This is a list of all comments for DIALIN-ACK-1.

Review Summary: No summary


----------------------------------------
File: DG/DG_Firmware_Simulator.py
Revision Comment by pmontazemi on 27 March 2020, 08:36 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1522

  Remove extra line

  Reply by plucia on 31 March 2020, 11:57
  > Requested changes are now added

    Reply by pmontazemi on 01 April 2020, 08:42
    > RESOLVED.

Revision Comment by pmontazemi on 27 March 2020, 08:36 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1523

  Isn't the 1 second sleep going to interfere with the faster
  messages transmitted and received by the laptop+CAN Analyzer
  node?

  Reply by plucia on 31 March 2020, 09:47
  > This script has only been moved or renamed, as I am not the
  > original author. 
  > In this section, it appears to just be emitting a dummy
  > payload to the DG sync broadcast channel id every second. I
  > don't see how it could interfere with other messages being
  > sent on the CAN bus since it is just adding a little traffic
  > to the bus once every second. The type of other nodes on the
  > bus shouldn't matter.

    Reply by pmontazemi on 01 April 2020, 08:44
    > RESOLVED.

----------------------------------------
File: DG/DialysateGenerator.py
Revision Comment by Behrouz NematiPour on 01 April 2020, 11:02 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1600

  I would keep bytearray as one word since it's a python type .

  Reply by Dara Navaei on 19 October 2023, 13:19
  > RESOLVED

Revision Comment by pmontazemi on 27 March 2020, 08:39 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1524

  Once Dialin is added to nightly builds, dates and authors will
  be updated as well.

  Reply by plucia on 31 March 2020, 11:57
  > For now, I've updated them here manually (see latest changes)

    Reply by pmontazemi on 01 April 2020, 08:42
    > RESOLVED.

Revision Comment by pmontazemi on 27 March 2020, 08:43 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1525

  This functions shall be updated because there are more details
  to the various DG states and related modes of operation (not as
  simple as fill and drain).

  Reply by pmontazemi on 28 April 2020, 08:34
  > This code has been modified since.

    Reply by pmontazemi on 28 April 2020, 08:34
    > RESOLVED.

----------------------------------------
File: DialIn/CoreCANProtocol.py
Revision Comment by pmontazemi on 27 March 2020, 08:44 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1526

  Author should list only last person who touched this code.

  Reply by plucia on 31 March 2020, 11:56
  > Requested changes are now added

    Reply by pmontazemi on 01 April 2020, 08:42
    > RESOLVED.

Revision Comment by pmontazemi on 27 March 2020, 08:59 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1527

  Provide """     """   section in class header, also provide the
  process by which these channel IDs get updated, using which
  files, located where.

  Reply by pmontazemi on 01 April 2020, 08:44
  > RESOLVED.

----------------------------------------
File: HD/HD_TestScript.py
Revision Comment by pmontazemi on 27 March 2020, 09:21 
https://devapps.diality.us/cru/DIALIN-ACK-1#c1528

  Generally speaking, do we want to have a mix of Dialin API code
  and Python test scripts?

  Reply by plucia on 31 March 2020, 09:34
  > No, I think we need to separate them, potentially putting
  > them in a different repository altogether in the future
  > 
  > To avoid deleting people's work, I didn't delete test scripts
  > in this commit. In future commits, I will reach out to people
  > and let them know before they are deleted or moved

    Reply by pmontazemi on 01 April 2020, 08:43
    > RESOLVED.


---

ID: DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1

Title: DIALIN-ACK
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Moderator: plucia
Reviewers: (0 active, 2 completed*)
     Behrouz NematiPour   (*)
     pmontazemi   (*)