This is a list of all comments for DIALIN-DEN-10602-2.

Review Summary: No summary


----------------------------------------
File: dialin/ui/hd_simulator.py
Revision Comment by Michael Garthwaite on 15 December 2021, 11:04 
https://devapps.diality.us/cru/DIALIN-DEN-10602-2#c11534

  This function header is missing type hinting

  Reply by Behrouz NematiPour on 15 December 2021, 15:52
  > Fixed.
  > If Crucible doesn't show you the latest update please drag
  > the comment slider (which is on top of the current file view)
  > right knob to the right end under the last commit.

    Reply by Michael Garthwaite on 15 December 2021, 17:50
    > RESOLVED

Revision Comment by Michael Garthwaite on 15 December 2021, 09:44 
https://devapps.diality.us/cru/DIALIN-DEN-10602-2#c11530

  The names for these new parameters are named "final uf volume"
  and "final uf rate" for treatment log based on discussion and
  PRS.

  Reply by Behrouz NematiPour on 15 December 2021, 15:48
  > According to PRS 178:
  > These are actually:
  >  - "Final Target Ultrafiltration Volume"
  >  - "Final Target Ultrafiltration Rate"
  > for simplicity, the "Final" portion has been removed and only
  > the "Target" is used since all SW knows them as "Target"
  > only.

    Reply by Behrouz NematiPour on 15 December 2021, 16:30
    > That "origin" is intentional.
    > I actually tried to find a word with a correct meaning with
    > the same character length as Target, Actual, Origin. Since
    > this one is not showing up on any scrip or file other than
    > the code, that is fine.

      Reply by Michael Garthwaite on 15 December 2021, 17:50
      > RESOLVED

Revision Comment by Michael Garthwaite on 15 December 2021, 09:47 
https://devapps.diality.us/cru/DIALIN-DEN-10602-2#c11531

  "final uf volume" and "final uf rate"

  Reply by Behrouz NematiPour on 15 December 2021, 15:44
  > According to PRS 178:
  > These are actually:
  >  - "Final Target Ultrafiltration Volume"
  >  - "Final Target Ultrafiltration Rate"
  > for simplicity, the "Final" portion has been removed and only
  > the "Target" is used since all SW knows them as "Target"
  > only.

    Reply by Michael Garthwaite on 15 December 2021, 16:11
    > My mistake. i was thinking the parameters 'origin_uf_rate'
    > and 'origin_uf_volume' need to be reworded since its now
    > the Prescribed Ultrafiltration volume/rate

      Reply by Behrouz NematiPour on 15 December 2021, 16:27
      > That one is intentional.
      > I actually tried to find a word with a correct meaning
      > with the same character length as Target, Actual, Origin.
      > Since this one is not showing up on any scrip or file
      > other than the code, that is fine.

        Reply by Michael Garthwaite on 15 December 2021, 17:50
        > RESOLVED

----------------------------------------
File: dialin/hd/ui_proxy.py
Revision Comment by Sean Nash on 15 December 2021, 10:39 
https://devapps.diality.us/cru/DIALIN-DEN-10602-2#c11532

  These field numbers are off now.  Start and End field numbers
  should be the same for each parameter parsed.

  Reply by Behrouz NematiPour on 15 December 2021, 15:01
  > Thanks for the fix.
  > I fixed the other functions as well.

    Reply by Sean Nash on 30 December 2021, 09:41
    > RESOLVED.

Revision Comment by Michael Garthwaite on 15 December 2021, 10:54 
https://devapps.diality.us/cru/DIALIN-DEN-10602-2#c11533

  Start and End field positions are out of alignment for response
  as well.

  Reply by Behrouz NematiPour on 15 December 2021, 15:03
  > Thanks for pointing that out.
  > Fixed.

    Reply by Michael Garthwaite on 15 December 2021, 15:08
    > RESOLVED


---

ID: DIALIN-DEN-10602-2 https://devapps.diality.us/cru/DIALIN-DEN-10602-2

Title: DIALIN-DEN-10602_UI DEV Add PatientID PreTreatment
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei