This is a list of all comments for DIALIN-DEN-11928-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/dialysate_fill.py
Revision Comment by Michael Garthwaite on 28 March 2022, 10:32 
https://devapps.diality.us/cru/DIALIN-DEN-11928-1#c12702

  Please update the documentation.

  Reply by Michael Garthwaite on 31 March 2022, 13:37
  > RESOLVED.

Revision Comment by Michael Garthwaite on 28 March 2022, 10:34 
https://devapps.diality.us/cru/DIALIN-DEN-11928-1#c12703

  Please change the struct.unpack parameters from big endian to
  little endian. Reference below:
  
  https://docs.python.org/3/library/struct.html#format-characters

  Reply by Dara Navaei on 31 March 2022, 13:17
  > Done.

    Reply by Michael Garthwaite on 31 March 2022, 13:37
    > RESOLVED.

Revision Comment by Michael Garthwaite on 28 March 2022, 10:31 
https://devapps.diality.us/cru/DIALIN-DEN-11928-1#c12700

  Please update the documentation.

  Reply by Dara Navaei on 31 March 2022, 13:18
  > Done.

    Reply by Michael Garthwaite on 31 March 2022, 13:38
    > RESOLVED.

Revision Comment by Michael Garthwaite on 28 March 2022, 10:31 
https://devapps.diality.us/cru/DIALIN-DEN-11928-1#c12701

  Please update the documentation.

  Reply by Dara Navaei on 31 March 2022, 13:19
  > Done.

    Reply by Michael Garthwaite on 31 March 2022, 13:38
    > RESOLVED.

----------------------------------------
File: dialin/dg/gen_idle.py
Revision Comment by Michael Garthwaite on 28 March 2022, 10:36 
https://devapps.diality.us/cru/DIALIN-DEN-11928-1#c12704

  Please change the struct.unpack parameters from big endian to
  little endian. Reference below:
  
  https://docs.python.org/3/library/struct.html#format-characters

  Reply by Dara Navaei on 31 March 2022, 13:14
  > Done.

    Reply by Michael Garthwaite on 31 March 2022, 13:37
    > RESOLVED.

----------------------------------------
File: dialin/dg/conductivity_sensors.py
Revision Comment by Michael Garthwaite on 30 March 2022, 14:58 
https://devapps.diality.us/cru/DIALIN-DEN-11928-1#c12731

  Commenting out these variables will cause out of sync issues
  between what is currently in DG develop. Current conductivity
  data struct in DG develop:
  
  /// Conductivity data struct.
      F32 roRejectionRatio;                   ///< RO rejection
  ratio
      F32 cpi;                                ///< CPi
  conductivity sensor value
      F32 cpo;                                ///< CPo
  conductivity sensor value
      F32 cd1;                                ///< CD1
  conductivity sensor value
      F32 cd2;                                ///< CD2
  conductivity sensor value
      F32 cpiRaw;                             ///< CPi raw
  conductivity sensor value (without 2% temperature compensated)
      F32 cpoRaw;                             ///< CPo raw
  conductivity sensor value (without 2% temperature compensated)
      F32 cd1Raw;                             ///< CD1 raw
  conductivity sensor value (without 2% temperature compensated)
      F32 cd2Raw;                             ///< CD2 raw
  conductivity sensor value (without 2% temperature compensated)
      U32 cpiSensorStatus;                    ///< CPi
  conductivity sensor status
      U32 cpoSensorStatus;                    ///< CPo
  conductivity sensor status
      U32 cd1SensorStatus;                    ///< CD1
  conductivity sensor status
      U32 cd2SensorStatus;                    ///< CD2
  conductivity sensor status
   CONDUCTIVITY_DATA_T;
  
  
  please be careful when we are merging this into staging

  Reply by Dara Navaei on 31 March 2022, 13:11
  > This was commented out for testing. It is back on.

    Reply by Michael Garthwaite on 31 March 2022, 13:37
    > RESOLVED.


---

ID: DIALIN-DEN-11928-1 https://devapps.diality.us/cru/DIALIN-DEN-11928-1

Title: DIALIN-DEN-11928_DG Conductivity Update
Statement of Objectives:


State: Closed

Summary: 

Author: hnguyen
Moderator: hnguyen
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei
     Behrouz NematiPour