This is a list of all comments for DIALIN-DEN-11980-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/treatment.py
Revision Comment by Sean Nash on 16 February 2022, 09:34 
https://devapps.diality.us/cru/DIALIN-DEN-11980-1#c11921

  Should the new current treatment params above be reset in this
  function?

  Reply by Michael Garthwaite on 16 February 2022, 09:49
  > I'm indifferent to the idea. Since the current values are
  > more of a "real time" feature and don't need a broadcast
  > message to update their values. The other properties need a
  > reset for this reason. What do you think?

    Reply by Sean Nash on 16 February 2022, 10:28
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 17 February 2022, 09:58 
https://devapps.diality.us/cru/DIALIN-DEN-11980-1#c11993

  I think soon we need to replace these error-prone indexing data
  extraction with the new conversion functions in the utility
  module.
  As an example take a look at ui/hd_simulator.py@1926:
  {code}
      @publish(["ui_version"])
      def _handler_ui_version(self, message) -> None:
          """
          Handles the ui version response
          @param message: The ui version response message
          @return: None
          """
          payload = message['message']
          index = DenaliMessage.PAYLOAD_START_INDEX
          major, index = bytearray_to_byte(payload, index, False)
          minor, index = bytearray_to_byte(payload, index, False)
          micro, index = bytearray_to_byte(payload, index, False)
          build, index = bytearray_to_short(payload, index,
  False)
          compt, index = bytearray_to_integer(payload, index,
  False)
  
          self.ui_version =
  f"v{major}.{minor}.{micro}.{build}.{compt}"
          self.logger.debug(f"UI VERSION: {self.ui_version}")
  
          if self.console_out:
              print("Version:", self.ui_version)
  {code}

  Reply by Michael Garthwaite on 17 February 2022, 10:07
  > that'll be done in another sprint as ALL methods need to
  > convert to that.

    Reply by Behrouz NematiPour on 17 February 2022, 10:20
    > Totally agree,
    > I just wanted to make sure we've planned to do that.
    > RESOLVED.

----------------------------------------
File: dialin/hd/blood_flow.py
Revision Comment by Behrouz NematiPour on 17 February 2022, 10:50 
https://devapps.diality.us/cru/DIALIN-DEN-11980-1#c12011

  Please update the BloodFlow and DialysateFlow in the
  hd_simulator as well.

  Reply by Michael Garthwaite on 17 February 2022, 11:43
  > Fixed. Thanks!

    Reply by Behrouz NematiPour on 22 February 2022, 11:40
    > RESOLVED.

Revision Comment by Sean Nash on 16 February 2022, 09:28 
https://devapps.diality.us/cru/DIALIN-DEN-11980-1#c11916

  Why is I capitalized?

  Reply by Michael Garthwaite on 16 February 2022, 09:43
  > struct.py lists the args to unpack as such:
  > 
  > "The remaining chars indicate types of args and must match
  > exactly;
  > these can be preceded by a decimal repeat count:
  >   x: pad byte (no data);
  >  c:char;
  >  b:signed byte; 
  > B:unsigned byte;
  >   ?: _Bool (requires C99; if not available, char is used
  > instead)
  >   h:short; 
  > H:unsigned short;
  > i:int;
  > I:unsigned int; (Capital i)
  > l:long; 
  > L:unsigned long;
  > f:float; 
  > d:double; 
  > e:half-float."
  > 
  > Rotor_count is sent from the HD as an unsigned int (U32).

    Reply by Sean Nash on 16 February 2022, 10:29
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 17 February 2022, 10:27 
https://devapps.diality.us/cru/DIALIN-DEN-11980-1#c11996

  Just to keep the main reference link:
  https://docs.python.org/3/library/struct.html#format-characters

  Reply by Dara Navaei on 19 October 2023, 13:04
  > RESOLVED

----------------------------------------
File: dialin/hd/hemodialysis_device.py
Revision Comment by Sean Nash on 16 February 2022, 09:31 
https://devapps.diality.us/cru/DIALIN-DEN-11980-1#c11918

  Brief looks wrong.

  Reply by Michael Garthwaite on 16 February 2022, 10:12
  > Fixed. Thanks!

    Reply by Sean Nash on 16 February 2022, 10:28
    > RESOLVED.

Revision Comment by Sean Nash on 16 February 2022, 09:31 
https://devapps.diality.us/cru/DIALIN-DEN-11980-1#c11919

  This looks wrong too.

  Reply by Michael Garthwaite on 16 February 2022, 10:12
  > Fixed. Thanks!

    Reply by Sean Nash on 16 February 2022, 10:29
    > RESOLVED.


---

ID: DIALIN-DEN-11980-1 https://devapps.diality.us/cru/DIALIN-DEN-11980-1

Title: DIALIN-DEN-11980_SW Dev Sprint 64
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (1 active, 2 completed*)
     Dara Navaei   (*)
     Behrouz NematiPour   (*)
     Sean Nash