This is a list of all comments for DIALIN-DEN-12224-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/fans.py
Revision Comment by Michael Garthwaite on 01 April 2022, 10:57 
https://devapps.diality.us/cru/DIALIN-DEN-12224-1#c12761

  Please change the byte order for struct.unpack

  Reply by Dara Navaei on 18 June 2022, 14:46
  > Will be addressed in in DIAL-171.

    Reply by Michael Garthwaite on 20 June 2022, 13:59
    > RESOLVED.

Revision Comment by Michael Garthwaite on 01 April 2022, 10:59 
https://devapps.diality.us/cru/DIALIN-DEN-12224-1#c12762

  the old comment is correct. The else branch statement handles
  no content.

  Reply by Dara Navaei on 23 May 2022, 14:51
  > Done.

    Reply by Michael Garthwaite on 08 June 2022, 11:13
    > RESOLVED

----------------------------------------
File: dialin/hd/pretreatment.py
Revision Comment by Michael Garthwaite on 01 April 2022, 10:52 
https://devapps.diality.us/cru/DIALIN-DEN-12224-1#c12758

  Please implement a getter for wet_self_test_states

  Reply by Dara Navaei on 18 June 2022, 14:55
  > Done.

    Reply by Michael Garthwaite on 20 June 2022, 14:00
    > RESOLVED.

Revision Comment by Michael Garthwaite on 01 April 2022, 10:57 
https://devapps.diality.us/cru/DIALIN-DEN-12224-1#c12760

  Please change the byte order of struct.unpack

  Reply by Dara Navaei on 20 June 2022, 13:56
  > Will be addressed in in DIAL-171.

    Reply by Michael Garthwaite on 20 June 2022, 13:59
    > RESOLVED.

Revision Comment by Michael Garthwaite on 01 April 2022, 10:53 
https://devapps.diality.us/cru/DIALIN-DEN-12224-1#c12759

  As much as I dont like this (Values should be left numerical.
  Let the API user convert it to something easier to read if they
  want), please add the same value check for wet_self_test_state.

  Reply by Dara Navaei on 18 June 2022, 14:54
  > Done.

    Reply by Michael Garthwaite on 20 June 2022, 13:59
    > RESOLVED.

----------------------------------------
File: dialin/dg/concentrate_pumps.py
Revision Comment by Michael Garthwaite on 01 April 2022, 11:02 
https://devapps.diality.us/cru/DIALIN-DEN-12224-1#c12763

  Please change the byte order for struct.unpack

  Reply by Behrouz NematiPour on 07 April 2022, 12:26
  > We had a conversation with [~mgarthwaite] and all these
  > functions are going to use the functions in the
  > conversions.py since this method of doing it is very
  > error-prone.
  > We should plan soon to make these changes.

    Reply by Dara Navaei on 23 May 2022, 14:50
    > Will be addressed in in DIAL-171.

      Reply by Michael Garthwaite on 20 June 2022, 13:59
      > RESOLVED.

----------------------------------------
File: dialin/dg/conductivity_sensors.py
Revision Comment by Michael Garthwaite on 01 April 2022, 10:51 
https://devapps.diality.us/cru/DIALIN-DEN-12224-1#c12757

  Please change the byte order for the .unpack

  Reply by Behrouz NematiPour on 07 April 2022, 12:27
  > Same here [ using conversaions.py ]

    Reply by Dara Navaei on 20 June 2022, 13:56
    > Will be addressed in in DIAL-171.

      Reply by Michael Garthwaite on 20 June 2022, 14:00
      > RESOLVED.


---

ID: DIALIN-DEN-12224-1 https://devapps.diality.us/cru/DIALIN-DEN-12224-1

Title: DIALIN-DEN-12224_DG HD Dev Switches Monitor
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (1 active, 2 completed*)
     Michael Garthwaite   (*)
     Behrouz NematiPour   (*)
     Sean Nash