DIALIN-DEN-12716-1 DIALIN-DEN-12716_UI BN S70

closed on 08 Sep 22

Author

Moderator

Reviewers

DIALIN-DEN-12716_UI BN S70

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 20

dialin 0
- Folder dialin 0
  - Folder common 0
    - File alarm_defs.py 0 Remove
    - File dg_defs.py 0 Remove
    - File hd_defs.py 0 Remove
    - File msg_defs.py 17 Remove
    - File msg_ids.py 0 Remove
  - Folder dg 0
    - File conductivity_sensors.py 0 Remove
    - File dialysate_fill.py 0 Remove
    - File dialysate_generator.py 0 Remove
    - File gen_idle.py 0 Remove
    - File idle_badfill_substates.py 0 Remove
    - File ro_pump.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
  - Folder ui 0
    - File dg_simulator.py 0 Remove
    - File hd_simulator.py 0 Remove
    - File hd_simulator_alarms.py 3 Remove
  - Folder utils 0
    - File conversions.py 0 Remove
- Folder tests 0
  - File dg_nvm_scripts.py 0 Remove
  - File dg_tests.py 0 Remove
  - File hd_nvm_scripts.py 0 Remove
  - File test_conductivity.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	33m	7	updated
Michael Garthwaite	Reviewer - Complete	29m	4	RESOLVED.
Sean Nash	Reviewer - Complete	21m	9	Ok, let's do that. RESOLVED.
Dara Navaei	Reviewer - 0% reviewed	11m
Tiffany Mejia	Reviewer - Complete	22m
Total		1h 58m	20

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-12716-1

DIALIN-DEN-12716_UI BN S70

DIALIN-DEN-12716-1 20

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN-DEN-12716_UI BN S70

DIALIN-DEN-12716-1 20

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time