This is a list of all comments for DIALIN-DEN-12716-1.

Review Summary: No summary


----------------------------------------
File: dialin/common/msg_defs.py
Revision Comment by Sean Nash on 01 July 2022, 10:46 
https://devapps.diality.us/cru/DIALIN-DEN-12716-1#c13246

  What criteria is used to determine whether a message is
  included in this list?

  Reply by Behrouz NematiPour on 01 July 2022, 11:03
  > Probably because assuming that the list of ACK_NOT_REQUIRED
  > messages (at least at the time of implementation) was a
  > shorter list.

    Reply by Sean Nash on 06 July 2022, 09:27
    > Not sure a list is appropriate.  And if list does make
    > sense, should probably be a list of messages that do
    > require ACK (as generally we do not want Dialin ACKing - we
    > want Dialin to be passive and let HD/DG/UI do the ACKing).
    > Let's discuss with Michael.

      Reply by Behrouz NematiPour on 26 July 2022, 17:43
      > I totally agree.
      > This is the Dialin design, I am just using the API.
      > I think we should create a task on the Dialin board and
      > follow up on that ticket.

        Reply by Sean Nash on 08 September 2022, 17:02
        > Ok, let's do that.  RESOLVED.

Revision Comment by Sean Nash on 01 July 2022, 10:44 
https://devapps.diality.us/cru/DIALIN-DEN-12716-1#c13243

  Why are there 3 of these?

  Reply by Behrouz NematiPour on 01 July 2022, 17:49
  > Wow, eagle-eye,
  > duplicates removed.

    Reply by Sean Nash on 06 July 2022, 09:26
    > RESOLVED.

Revision Comment by Sean Nash on 01 July 2022, 10:45 
https://devapps.diality.us/cru/DIALIN-DEN-12716-1#c13244

  Why are there 2 of these?

  Reply by Behrouz NematiPour on 01 July 2022, 17:49
  > duplicates removed.

    Reply by Sean Nash on 06 July 2022, 09:26
    > RESOLVED.

Revision Comment by Michael Garthwaite on 07 July 2022, 13:24 
https://devapps.diality.us/cru/DIALIN-DEN-12716-1#c13273

  was MSG_ID_HD_ACCELEROMETER_DATA supposed to be removed as
  well?

  Reply by Behrouz NematiPour on 08 September 2022, 16:13
  > updated

    Reply by Michael Garthwaite on 08 September 2022, 16:28
    > RESOLVED.

Revision Comment by Sean Nash on 01 July 2022, 10:45 
https://devapps.diality.us/cru/DIALIN-DEN-12716-1#c13245

  Why are there 2 of these?

  Reply by Behrouz NematiPour on 01 July 2022, 17:49
  > Wow, eagle-eye,
  > duplicates removed.

    Reply by Sean Nash on 06 July 2022, 09:27
    > RESOLVED.

----------------------------------------
File: dialin/ui/hd_simulator_alarms.py
Revision Comment by Michael Garthwaite on 06 July 2022, 11:05 
https://devapps.diality.us/cru/DIALIN-DEN-12716-1#c13270

  Please add data types of the parameters.

  Reply by Behrouz NematiPour on 08 September 2022, 16:12
  > Updated.

    Reply by Michael Garthwaite on 08 September 2022, 16:28
    > RESOLVED.


---

ID: DIALIN-DEN-12716-1 https://devapps.diality.us/cru/DIALIN-DEN-12716-1

Title: DIALIN-DEN-12716_UI BN S70
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 3 completed*)
     Sean Nash   (*)
     Tiffany Mejia   (*)
     Michael Garthwaite   (*)
     Dara Navaei