This is a list of all comments for DIALIN-DEN-13460-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/concentrate_pumps.py
Revision Comment by Behrouz NematiPour on 16 September 2022, 16:57 
https://devapps.diality.us/cru/DIALIN-DEN-13460-1#c13791

  conversion.py

  Reply by Dara Navaei on 21 September 2022, 16:11
  > I believe there has been a request in the DIAL project to
  > convert these to conversion.

    Reply by Behrouz NematiPour on 22 September 2022, 02:33
    > Sure there is.
    > But if you keep using the old method we are never done.
    > Please while you develop/modify the part of the code you
    > can update please do.
    > 
    > [~mgarthwaite],
    > What is the plan for the following task?
    > DIAL-171 : Using conversions functions for data instead of
    > index-based

      Reply by Sean Nash on 29 September 2022, 16:16
      > I think we do want to switch over to using the conversion
      > function.  Not necessarily the highest priority task
      > since old way works too.
      > If creating a new sync function, let's use conversion
      > function.  If modifying an existing sync function, change
      > to using conversion function is optional but preferable.

        Reply by Behrouz NematiPour on 29 September 2022, 16:40
        > RESOLVED.

Revision Comment by Michael Garthwaite on 06 September 2022, 11:00 
https://devapps.diality.us/cru/DIALIN-DEN-13460-1#c13709

  What's the difference between target speed and set speed in
  this message?

  Reply by Dara Navaei on 21 September 2022, 17:05
  > Target speed is the final target, while the set speed is the
  > interim target speed for ramp up and ramp down.

    Reply by Michael Garthwaite on 28 September 2022, 13:31
    > RESOVLED.

      Reply by Dara Navaei on 19 October 2023, 13:00
      > RESOLVED

----------------------------------------
File: dialin/dg/load_cells.py
Revision Comment by Behrouz NematiPour on 16 September 2022, 16:55 
https://devapps.diality.us/cru/DIALIN-DEN-13460-1#c13789

  I thought we talked about using the functions in conversion.py,
  right?

  Reply by Dara Navaei on 21 September 2022, 17:07
  > I believe there has been a request in the DIAL project to
  > convert these to conversion.

    Reply by Behrouz NematiPour on 29 September 2022, 16:41
    > RESOLVED.

----------------------------------------
File: dialin/dg/dialysate_flow_sensor.py
Revision Comment by Behrouz NematiPour on 16 September 2022, 16:56 
https://devapps.diality.us/cru/DIALIN-DEN-13460-1#c13790

  conversion.py ?

  Reply by Dara Navaei on 21 September 2022, 17:07
  > I believe there has been a request in the DIAL project to
  > convert these to conversion.

    Reply by Behrouz NematiPour on 29 September 2022, 16:40
    > RESOLVED.


---

ID: DIALIN-DEN-13460-1 https://devapps.diality.us/cru/DIALIN-DEN-13460-1

Title: DIALIN-DEN-13460_DG HD Dev HD DG Dvt Update Part 2
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (1 active, 2 completed*)
     Michael Garthwaite   (*)
     Behrouz NematiPour   (*)
     Sean Nash