This is a list of all comments for DIALIN-DEN-13903-1.

Review Summary: No summary


----------------------------------------
File: dialin/common/hd_defs.py
Revision Comment by Behrouz NematiPour on 22 September 2022, 09:57 
https://devapps.diality.us/cru/DIALIN-DEN-13903-1#c13883

  Why are these removed?
  It might be used in our SquishQt dev tests.

  Reply by Behrouz NematiPour on 03 October 2022, 11:58
  > [~mgarthwaite],
  > please revert back these changes.
  > it also broke the Simulator.

    Reply by Michael Garthwaite on 03 October 2022, 13:20
    > The classes that have been removed are duplicates and wont
    > be reverted. Please review the following lines:
    > 
    > PreTreatmentModeStates ( line 235) == PreTreatmentSubModes
    > (line 82)
    > 
    > PreTreatmentSampleWaterStates ( line 249 ) ==
    > PreTreatmentSampleWaterStates ( line 96 )
    > 
    > PreTreatmentConsumableSelfTeststates ( line 257 ) ==
    > PreTreatmentConsumableSelfTeststates ( line 104 )
    > 
    > PreTreatmentNoCartSelfTestsStates ( line 268 ) ==
    > PreTreatmentNoCartSelfTestStates ( line 115 )
    > 
    > PreTreatmentDrySelfTestStates ( line 147 ) ==
    > PreTreatmentDrySelfTestsStates ( line 288 )
    > 
    > PreTreatmentPrimeStates ( line 163 ) ==
    > PreTreatmentPrimeStates ( line 304 )
    > 
    > StandbyStates ( line 344 ) == HDStandbyStates ( line 35 )

      Reply by Behrouz NematiPour on 03 October 2022, 16:28
      > Thanks for the clarification.
      > RESOLVED.

----------------------------------------
File: dialin/hd/blood_flow.py
Revision Comment by Sean Nash on 22 September 2022, 09:49 
https://devapps.diality.us/cru/DIALIN-DEN-13903-1#c13878

  Missing payload.

  Reply by Michael Garthwaite on 12 October 2022, 08:54
  > Fixed. Thanks!

    Reply by Sean Nash on 12 October 2022, 09:00
    > RESOLVED.

----------------------------------------
File: dialin/hd/dialysate_inlet_flow.py
Revision Comment by Sean Nash on 22 September 2022, 09:48 
https://devapps.diality.us/cru/DIALIN-DEN-13903-1#c13877

  Missing payload.

  Reply by Michael Garthwaite on 12 October 2022, 08:54
  > Fixed. Thanks!

    Reply by Sean Nash on 12 October 2022, 09:00
    > RESOLVED.

----------------------------------------
File: dialin/hd/dialysate_outlet_flow.py
Revision Comment by Sean Nash on 22 September 2022, 10:27 
https://devapps.diality.us/cru/DIALIN-DEN-13903-1#c13893

  Missing payload.

  Reply by Michael Garthwaite on 12 October 2022, 08:53
  > Fixed. Thanks!

    Reply by Sean Nash on 12 October 2022, 09:01
    > RESOLVED.


---

ID: DIALIN-DEN-13903-1 https://devapps.diality.us/cru/DIALIN-DEN-13903-1

Title: DIALIN-DEN-13903_S80 MG Dial 204
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (0 active, 3 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     Behrouz NematiPour   (*)