This is a list of all comments for DIALIN-DEN-14307-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/heat_disinfect_active_cool.py
Revision Comment by Michael Garthwaite on 19 December 2022, 16:00 
https://devapps.diality.us/cru/DIALIN-DEN-14307-1#c15308

  Does this message need a broadcast override for V&V?

  Reply by Dara Navaei on 21 December 2022, 11:24
  > No these are only broadcast data. We do not override the
  > states of a mode.

    Reply by Sean Nash on 21 December 2022, 13:05
    > I think he meant do we need an override for the broadcast
    > interval.

      Reply by Michael Garthwaite on 21 December 2022, 15:02
      > Discussion with V&V has determined that we dont need an
      > override for the time being.

        Reply by Michael Garthwaite on 21 December 2022, 15:02
        > RESOLVED

----------------------------------------
File: dialin/dg/concentrate_pumps.py
Revision Comment by Michael Garthwaite on 19 December 2022, 15:50 
https://devapps.diality.us/cru/DIALIN-DEN-14307-1#c15302

  Can these fields be a value that is not 0 or 1? Seems weird to
  have them be unpacked and casted as a bool only to have the
  override parameters have int instead of bool.

  Reply by Dara Navaei on 21 December 2022, 11:23
  > [~snash] could you please respond to this comment?

    Reply by Sean Nash on 21 December 2022, 11:39
    > Prefer Dialin script writers see T/F for these.  F/W sends
    > BOOL which is essentially a U32.  Just using unpack 'I'
    > since it's best fit.

      Reply by Michael Garthwaite on 21 December 2022, 14:58
      > RESOLVED


---

ID: DIALIN-DEN-14307-1 https://devapps.diality.us/cru/DIALIN-DEN-14307-1

Title: DIALIN-DEN-14307_DG HD Dev HD DG Dvt Update Part 6
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (3 active, 0 completed*)
     Sean Nash
     Michael Garthwaite
     Behrouz NematiPour