This is a list of all comments for DIALIN-DEN-14344-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/air_pump.py
Revision Comment by Sean Nash on 19 December 2022, 17:07 
https://devapps.diality.us/cru/DIALIN-DEN-14344-1#c15358

  Need class header.

  Reply by Michael Garthwaite on 22 December 2022, 10:23
  > Fixed. Thanks!

    Reply by Sean Nash on 22 December 2022, 13:19
    > RESOLVED.

Revision Comment by Sean Nash on 19 December 2022, 17:07 
https://devapps.diality.us/cru/DIALIN-DEN-14344-1#c15359

  Need function header.

  Reply by Michael Garthwaite on 22 December 2022, 10:23
  > Fixed. Thanks!

    Reply by Sean Nash on 22 December 2022, 13:19
    > RESOLVED.

Revision Comment by Sean Nash on 19 December 2022, 17:09 
https://devapps.diality.us/cru/DIALIN-DEN-14344-1#c15361

  Add Publish list.

  Reply by Michael Garthwaite on 22 December 2022, 10:23
  > Fixed. Thanks!

    Reply by Sean Nash on 22 December 2022, 13:20
    > RESOLVED.

Revision Comment by Sean Nash on 22 November 2022, 12:08 
https://devapps.diality.us/cru/DIALIN-DEN-14344-1#c15050

  pass?

  Reply by Sean Nash on 19 December 2022, 17:08
  > RESOLVED.

Revision Comment by Sean Nash on 19 December 2022, 17:11 
https://devapps.diality.us/cru/DIALIN-DEN-14344-1#c15362

  Isn't this function already declared in air_trap.py?

  Reply by Michael Garthwaite on 22 December 2022, 10:23
  > Fixed. Thanks!

    Reply by Sean Nash on 22 December 2022, 13:22
    > RESOLVED.

----------------------------------------
File: dialin/hd/hemodialysis_device.py
Revision Comment by Sean Nash on 19 December 2022, 17:05 
https://devapps.diality.us/cru/DIALIN-DEN-14344-1#c15357

  Does HD need a compatibility rev too (like you added to DG)?

  Reply by Michael Garthwaite on 22 December 2022, 10:09
  > Not in this file. It is within UI proxy since that is where
  > the method for requesting the HD version. For the DG, that
  > method is within dialysate_generator.py.

    Reply by Sean Nash on 22 December 2022, 13:23
    > RESOLVED.


---

ID: DIALIN-DEN-14344-1 https://devapps.diality.us/cru/DIALIN-DEN-14344-1

Title: DIALIN-DEN-14344_SW S85 MG Air Pump
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     Behrouz NematiPour