This is a list of all comments for DIALIN-DEN-15199-1.

Review Summary: No summary


----------------------------------------
File: dialin/common/test_config_defs.py
Revision Comment by Sean Nash on 26 April 2023, 08:22 
https://devapps.diality.us/cru/DIALIN-DEN-15199-1#c17247

  Add file header

  Reply by Dara Navaei on 26 April 2023, 09:08
  > The file heater will be added automatically in upon the
  > staging build.

    Reply by Sean Nash on 26 April 2023, 09:26
    > RESOLVED.

Revision Comment by Sean Nash on 26 April 2023, 08:22 
https://devapps.diality.us/cru/DIALIN-DEN-15199-1#c17246

  ???

  Reply by Dara Navaei on 26 April 2023, 09:07
  > This will be updated once we move to HD.

    Reply by Sean Nash on 26 April 2023, 09:26
    > RESOLVED.

----------------------------------------
File: dialin/dg/dg_test_configs.py
Revision Comment by Sean Nash on 26 April 2023, 08:23 
https://devapps.diality.us/cru/DIALIN-DEN-15199-1#c17248

  Add file header

  Reply by Dara Navaei on 26 April 2023, 09:08
  > The file header will be added upon the staging build.

    Reply by Sean Nash on 26 April 2023, 09:26
    > RESOLVED.

Revision Comment by Michael Garthwaite on 26 April 2023, 10:18 
https://devapps.diality.us/cru/DIALIN-DEN-15199-1#c17275

  Shouldnt this reset be in cmd_reset_all_test_configs()? It
  should also be executed after a successful message.

  Reply by Dara Navaei on 26 April 2023, 10:24
  > This is here is because when they request the configs I set
  > the dictionary to reset mode until the new values have been
  > received from the firmware and then the dictionary is updated
  > with the firmware values. Thanks I moved it to only execute
  > it if the message was received successfully.

    Reply by Michael Garthwaite on 26 April 2023, 11:04
    > RESOLVED.


---

ID: DIALIN-DEN-15199-1 https://devapps.diality.us/cru/DIALIN-DEN-15199-1

Title: DIALIN-DEN-15199_FW DN Sprint
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Tiffany Mejia
     Behrouz NematiPour
     jishii