This is a list of all comments for DIALIN-DEN-16093-1.

Review Summary: No summary


----------------------------------------
File: .gitignore
Revision Comment by Michael Garthwaite on 22 August 2023, 08:57 
https://devapps.diality.us/cru/DIALIN-DEN-16093-1#c18664

  Typical dialin projects don't have or generate a .metadata
  folder. How are you creating this and why does it need to be
  ignored?

  Reply by Vinayakam Mani on 22 August 2023, 13:42
  > it looks to be auto generated by PyCharm and was committed
  > earlier. Its removed now.

    Reply by Michael Garthwaite on 23 August 2023, 10:03
    > RESOLVED.

----------------------------------------
File: dialin/common/msg_ids.py
Revision Comment by Michael Garthwaite on 22 August 2023, 08:58 
https://devapps.diality.us/cru/DIALIN-DEN-16093-1#c18665

  Please change the naming of 0x83 to what you have in your
  latest common branch

  Reply by Vinayakam Mani on 22 August 2023, 13:40
  > Updated.

    Reply by Michael Garthwaite on 23 August 2023, 10:03
    > RESOLVED.


---

ID: DIALIN-DEN-16093-1 https://devapps.diality.us/cru/DIALIN-DEN-16093-1

Title: DIALIN-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Tiffany Mejia
     Dara Navaei
     Behrouz NematiPour