This is a list of all comments for DIALIN-DEN-16242-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/ui_proxy.py
Revision Comment by Sean Nash on 01 September 2023, 12:32 
https://devapps.diality.us/cru/DIALIN-DEN-16242-1#c18811

  Why is driving this change?  And should other proxy commands be
  changed as well?

  Reply by Michael Garthwaite on 01 September 2023, 12:41
  > Advantu team was assumed that false meant the proxy command
  > was not accepted.
  > 
  > When we proxy messages through dialin using the dialin
  > channels, the receiver ( HD or DG ) will ACK back in the
  > non-proxied channel. Dialin will only considers received
  > messages over its own set of CAN channels and will timeout
  > due the ACK from the receiver being sent on the non-dialin
  > channel
  > 
  > EX:
  > Dialin will send Pressure limits change request over 0x400
  > HD accepts the message and will ACK back over 0x010
  > HD sends Pressure limits change response over 0x010 ( Dialin
  > is monitoring via callback )
  > 
  > Proxy commands should be changed eventually... depends on how
  > the users are applying them ( if they are expecting and using
  > a return value like an override ). Older iterations of proxy
  > commands do not return anything nor expect a Denali protocol
  > ACK

    Reply by Sean Nash on 05 September 2023, 11:45
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DIALIN-DEN-16242-1 https://devapps.diality.us/cru/DIALIN-DEN-16242-1

Title: DIALIN-DEN-16242_Pressure Limit Request Fix
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Tiffany Mejia   (*)
     jpaguio
     Dara Navaei
     Behrouz NematiPour