This is a list of all comments for DIALIN-DEN-16454-1.

Review Summary: No summary


----------------------------------------
File: dialin/common/hd_defs.py
Revision Comment by Michael Garthwaite on 19 October 2023, 15:28 
https://devapps.diality.us/cru/DIALIN-DEN-16454-1#c19207

  Please remove blank line.

  Reply by vduong on 19 October 2023, 16:14
  > Done.

    Reply by Michael Garthwaite on 19 October 2023, 16:15
    > Resolved.

----------------------------------------
File: dialin/ui/hd_simulator.py
Revision Comment by Michael Garthwaite on 19 October 2023, 15:30 
https://devapps.diality.us/cru/DIALIN-DEN-16454-1#c19208

  These should not be commented out. Current FW builds have
  MSG_ID_PRESSURE_OCCLUSION_DATA = 0x9 with the following
  structure.
  
  /// Payload record structure for the pressure & occlusions data
  message.
  
      F32 arterialPressure;                   ///< Latest
  arterial pressure (mmHg)
      F32 venousPressure;                     ///< Latest venous
  pressure (mmHg)
      U32 bldPumpOcclusion;                   ///< Latest BP
  occlusion (no units)
      U32 presLimitState;                     ///< Current
  pressure limits state (enum-stabilization or stable)
      S32 artMinLimit;                        ///< Current
  arterial minimum pressure limit (mmHg)
      S32 artMaxLimit;                        ///< Current
  arterial maximum pressure limit (mmHg)
      S32 venMinLimit;                        ///< Current venous
  minimum pressure limit (mmHg)
      S32 venMaxLimit;                        ///< Current venous
  maximum pressure limit (mmHg)
      F32 arterialLongFilterPres;             ///< Latest long
  filtered arterial pressure (mmHg)
      F32 venousLongFilterPres;               ///< Latest long
  filtered venous pressure (mmHg)
   PRESSURE_OCCLUSION_DATA_T;

  Reply by Behrouz NematiPour on 19 October 2023, 15:36
  > [~mgarthwaite]
  > we needed to match it with UI and since UI code is freeze.

    Reply by Michael Garthwaite on 19 October 2023, 15:38
    > this message structure is in Release FW. What is the UI
    > going to with the incorrect message size?

      Reply by Behrouz NematiPour on 19 October 2023, 15:39
      > UI will ignore the last two values, which is not using
      > it.
      > FW can add extra fields, but for now if UI don't use it
      > or does not have to use it will just ignore.

        Reply by Michael Garthwaite on 19 October 2023, 15:42
        > If the UI can ignore the fields, then why does dialin
        > need to match the UI?

          Reply by Behrouz NematiPour on 19 October 2023, 16:08
          > good point.
          > Vy will fix it.

          Reply by vduong on 19 October 2023, 16:14
          > All set. I have reverted it

          Reply by Michael Garthwaite on 19 October 2023, 16:16
          > Resolved.

----------------------------------------
File: dialin/ui/dg_simulator.py
Revision Comment by Michael Garthwaite on 19 October 2023, 15:35 
https://devapps.diality.us/cru/DIALIN-DEN-16454-1#c19209

  Missing two fields. Current DG FW has MSG_ID_DG_HEATERS_DATA =
  0x2C as
  
  /// Heaters data structure.
  typedef struct
  
      F32 mainPrimayHeaterDC;                     ///< Main
  primary heater DC
      F32 smallPrimaryHeaterDC;                   ///< Small
  primary heater DC
      F32 trimmerHeaterDC;                        ///< Trimmer
  heater DC
      F32 primaryTargetTemp;                      ///< Primary
  heater target temperature
      F32 trimmerTargetTemp;                      ///< Trimmer
  heater target temperature
      U32 primaryHeaterState;                     ///< Primary
  heater state
      U32 trimmerHeaterState;                     ///< Trimmer
  heater state
      F32 primaryEfficiency;                      ///< Primary
  heater efficiency
      F32 primaryCalcTargetTemp;                  ///< Primary
  heater calculated target temperature
      F32 trimmerCalcCurrentTemp;                 ///< Trimmer
  heater calculated current temperature
      U32 trimmerUseLastDC;                       ///< Trimmer
  heater use last duty cycle
      F32 previsouFlow;                           ///< Trimmer
  heater previous flow L/min
      U32 controlCounter;                         ///< Trimmer
  heater control count
  
  HEATERS_DATA_T;

  Reply by Behrouz NematiPour on 19 October 2023, 15:38
  > [~mgarthwaite]
  > Ui code is frozen and we cannot change the UI code, so
  > matched with what currently exists in UI.
  > The attempt was to fix the integration tests, and we did not
  > go over all the messages API to fix them.
  > We can have it done later when have more time.

    Reply by Michael Garthwaite on 19 October 2023, 16:16
    > Resolved.


---

ID: DIALIN-DEN-16454-1 https://devapps.diality.us/cru/DIALIN-DEN-16454-1

Title: DIALIN-DEN-16454-UI-VD-S106 [ Final release integration tests fix ]
Statement of Objectives:


State: Closed

Summary: 

Author: vduong
Moderator: vduong
Reviewers: (4 active, 3 completed*)
     Michael Garthwaite   (*)
     msuleiman   (*)
     Behrouz NematiPour   (*)
     Sean Nash
     Tiffany Mejia
     jpaguio
     Dara Navaei