This is a list of all comments for DIALIN-DEN-3504-1.

Review Summary: No summary


----------------------------------------
File: dialin/common/msg_defs.py
Revision Comment by plucia on 02 November 2020, 11:21 
https://devapps.diality.us/cru/DIALIN-DEN-3504-1#c5862

  These two have the same ID

  Reply by qnguyen on 02 November 2020, 13:44
  > This is a part of DEN-4640. It has been fixed in the latest
  > develop branch.
  > MSG_ID_UI_ALARM_ACKNOWLEDGE has been removed and replaced
  > with MSG_ID_UI_ALARM_USER_ACKNOWLEDGE.

    Reply by plucia on 09 November 2020, 10:03
    > RESOLVED

----------------------------------------
File: dialin/dg/concentrate_pumps.py
Revision Comment by plucia on 18 November 2020, 17:53 
https://devapps.diality.us/cru/DIALIN-DEN-3504-1#c6259

  Use the Dialin enum here to avoid duplicating has_value

  Reply by qnguyen on 18 November 2020, 21:52
  > Done.

    Reply by plucia on 19 November 2020, 10:14
    > RESOLVED

----------------------------------------
File: dialin/dg/dialysate_generator.py
Revision Comment by Sean Nash on 09 November 2020, 10:14 
https://devapps.diality.us/cru/DIALIN-DEN-3504-1#c5936

  I'm not convinced we can change modes via Dialin command.  For
  one thing, many mode transitions are illegal and will cause a
  system fault.  But even if mode change is legal, changing via
  external command bypasses internal state machine constraints
  and workflow leaving you in a new mode without proper context.

  Reply by qnguyen on 09 November 2020, 11:54
  > Removed.

  Reply by plucia on 10 November 2020, 13:38
  > Sean isn't this part of the request in DIAL-2 - Set Operation
  > Modes? Maybe we should discuss

    Reply by Sean Nash on 16 November 2020, 08:27
    > Yes, it is, but with none of my concerns dealt with.  It
    > will not be this simple.

      Reply by Sean Nash on 20 November 2020, 09:50
      > RESOLVED.

----------------------------------------
File: dialin/dg/alarms.py
Revision Comment by pmontazemi on 04 November 2020, 08:43 
https://devapps.diality.us/cru/DIALIN-DEN-3504-1#c5905

  Why removed?

  Reply by qnguyen on 04 November 2020, 11:50
  > The alarm ids can be obtained directly from AlarmList class
  > in dialin/common/alarms_defs.py.

    Reply by pmontazemi on 10 November 2020, 18:37
    > RESOLVED.


---

ID: DIALIN-DEN-3504-1 https://devapps.diality.us/cru/DIALIN-DEN-3504-1

Title: DIALIN-DEN-3504_DG Dialysate Composition (1 of 2)
Statement of Objectives:


State: Closed

Summary: 

Author: qnguyen
Reviewers: (0 active, 3 completed*)
     Sean Nash   (*)
     plucia   (*)
     pmontazemi   (*)